You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/29 11:03:39 UTC

[GitHub] [incubator-yunikorn-core] adamantal opened a new pull request #180: [YUNIKORN-255] Cleanup code from event cache change

adamantal opened a new pull request #180:
URL: https://github.com/apache/incubator-yunikorn-core/pull/180


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #180: [YUNIKORN-255] Cleanup code from event cache change

Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-core/pull/180#issuecomment-651059124


   Hey @adamantal,  
   Your changes look good to me!
   
   <a href="https:&#x2F;&#x2F;travis-ci.org&#x2F;apache&#x2F;incubator-yunikorn-core&#x2F;builds&#x2F;703099996">View build log</a>
   
   ###### TravisBuddy Request Identifier: 344038f0-b9fd-11ea-a74d-ef5d1a577ce8
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-core] adamantal commented on pull request #180: [YUNIKORN-255] Cleanup code from event cache change

Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-core/pull/180#issuecomment-651041881


   Created a draft for this patch. This patch depends on YUNIKORN-256 - concretely on https://github.com/apache/incubator-yunikorn-core/pull/178 to be merged in first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #180: [YUNIKORN-255] Cleanup code from event cache change

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #180:
URL: https://github.com/apache/incubator-yunikorn-core/pull/180


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-core] adamantal commented on pull request #180: [YUNIKORN-255] Cleanup code from event cache change

Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-core/pull/180#issuecomment-651060531


   Tested locally (docker-desktop). It works as intended, without data races.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #180: [YUNIKORN-255] Cleanup code from event cache change

Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-core/pull/180#issuecomment-651042841


   ## Travis tests have failed
   
   Hey @adamantal,
   Please read the following log in order to understand the failure reason.
   It'll be awesome if you fix what's wrong and commit the changes.
   
   
   ### 1st Build
   
   <a href="https:&#x2F;&#x2F;travis-ci.org&#x2F;apache&#x2F;incubator-yunikorn-core&#x2F;jobs&#x2F;703098255">View build log</a>
   
   
   <details>
     <summary>
       <strong>
        curl -sSfL https:&#x2F;&#x2F;raw.githubusercontent.com&#x2F;golangci&#x2F;golangci-lint&#x2F;master&#x2F;install.sh | sh -s -- -b $(go env GOPATH)&#x2F;bin v1.22.2
       </strong>
     </summary>
   
   ```
   golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
   golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
   golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
   ```
   
   </details>
   
   
   <details>
     <summary>
       <strong>
        make lint
       </strong>
     </summary>
   
   ```
   running golangci-lint
   pkg/events/event_cache_test.go:106: File is not `gofmt`-ed with `-s` (gofmt)
   			ObjectID: "alloc" + strconv.Itoa(i / 2),
   			GroupID:  "app" + strconv.Itoa(i / 2),
   pkg/events/event_store_test.go:63: File is not `gofmt`-ed with `-s` (gofmt)
   			ObjectID: "alloc" + strconv.Itoa(i / 2),
   			GroupID:  "app" + strconv.Itoa(i / 2),
   Makefile:45: recipe for target 'lint' failed
   make: *** [lint] Error 1
   ```
   
   </details>
   
   
   ###### TravisBuddy Request Identifier: a86c9de0-b9f8-11ea-a74d-ef5d1a577ce8
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org