[GitHub] clintropolis commented on a change in pull request #6638: Fixed buckets histogram aggregator

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #6638: Fixed buckets histogram aggregator
URL: https://github.com/apache/incubator-druid/pull/6638#discussion_r246977043
 
 

 ##########
 File path: docs/content/development/extensions-core/approximate-histograms.md
 ##########
 @@ -92,17 +96,140 @@ query.
 |`numBuckets`             |Number of output buckets for the resulting histogram. Bucket intervals are dynamic, based on the range of the underlying data. Use a post-aggregator to have finer control over the bucketing scheme|7|
 |`lowerLimit`/`upperLimit`|Restrict the approximation to the given range. The values outside this range will be aggregated into two centroids. Counts of values outside this range are still maintained. |-INF/+INF|
 
+## Fixed Buckets Histogram
+
 
 Review comment:
   nit: I think it's worth calling out here that the fixed bucket implementation is recommended mostly for when you know what you are doing and why, and pointing to datasketches for general purpose histogramming needs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org