[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #11008: [Bug][Worker] Remove service dependency from worker module

[GitBox <gi...@apache.org>]

ruanwenjun commented on PR #11008:
URL: https://github.com/apache/dolphinscheduler/pull/11008#issuecomment-1186374708

   > > Good job, could you please remove the excludeFilters in WorkerServer
   > > https://github.com/apache/dolphinscheduler/blob/e1c78d1a49628f75c05904c5659844dae0fa137f/dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java#L54-L61
   > > 
   > > and I find the `dolphinscheduler-worker` module relies on `dolphinscheduler-server`, and` dolphinscheduler-server` relies on `dolphinscheduler-service` can we remove the `dolphinscheduler-service` in `dolphinscheduler-server`(You can do this in another PR if you want)?
   > 
   > If this dependency tree exists, we have to remove the `excludeFilters` AND the `dolphinscheduler-service` in `dolphinscheduler-server` at the same time.
   
   Yes, I just find we still rely on `dolphinscheduler-service` and `dolphinscheduler-dao` since we have the rely on `dolphinscheduler-server` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org