[GitHub] [nifi] natural commented on a change in pull request #3523: NIFI-6325 Adds support for AWS KMS Sensitive Property Provider.

[GitBox <gi...@apache.org>]

natural commented on a change in pull request #3523: NIFI-6325 Adds support for AWS KMS Sensitive Property Provider.
URL: https://github.com/apache/nifi/pull/3523#discussion_r293033103
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/pom.xml
 ##########
 @@ -26,11 +26,19 @@
         performs any decryption/retrieval of sensitive configuration properties.
     </description>
     <packaging>jar</packaging>
+    <properties>
+        <aws-java-sdk-version>1.11.461</aws-java-sdk-version>
+    </properties>
     <dependencies>
         <dependency>
             <groupId>org.apache.nifi</groupId>
             <artifactId>nifi-properties</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.amazonaws</groupId>
+            <artifactId>aws-java-sdk-kms</artifactId>
+            <version>${aws-java-sdk-version}</version>
+        </dependency>
 
 Review comment:
   I don't know if anything needs to be added or not, but I do know this dependency already exists in `nifi-nar-bundles/nifi-aws-bundle`.  Is that LICENSE/NOTICE sufficient, or do we need something else?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services