You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Marta Kuczora <ku...@cloudera.com> on 2016/11/24 15:59:24 UTC

Review Request 54066: HIVE-15283: Index is dropped from wrong table in the index_auto_mult_tables.q and index_auto_mult_tables_compact.q tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54066/
-----------------------------------------------------------

Review request for hive, Aihua Xu, Peter Vary, and Sergio Pena.


Bugs: HIVE-15283
    https://issues.apache.org/jira/browse/HIVE-15283


Repository: hive-git


Description
-------

Changed the table name to srcpart in the "DROP INDEX srcpart_index_bitmap on src" and "DROP INDEX srcpart_index_compact on src" statements.


Diffs
-----

  ql/src/test/queries/clientpositive/index_auto_mult_tables.q 823e373 
  ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q fbb8720 
  ql/src/test/results/clientpositive/index_auto_mult_tables.q.out a34654c 
  ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 33a52ff 

Diff: https://reviews.apache.org/r/54066/diff/


Testing
-------

Ran the q tests multiple times, since only the q tests and their output files were changed.


Thanks,

Marta Kuczora

Re: Review Request 54066: HIVE-15283: Index is dropped from wrong table in the index_auto_mult_tables.q and index_auto_mult_tables_compact.q tests

Posted by Barna Zsombor Klara <zs...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54066/#review156855
-----------------------------------------------------------


Ship it!




LGTM thanks for the patch.

- Barna Zsombor Klara


On Nov. 24, 2016, 3:59 p.m., Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54066/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 3:59 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Peter Vary, and Sergio Pena.
> 
> 
> Bugs: HIVE-15283
>     https://issues.apache.org/jira/browse/HIVE-15283
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changed the table name to srcpart in the "DROP INDEX srcpart_index_bitmap on src" and "DROP INDEX srcpart_index_compact on src" statements.
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables.q 823e373 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q fbb8720 
>   ql/src/test/results/clientpositive/index_auto_mult_tables.q.out a34654c 
>   ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 33a52ff 
> 
> Diff: https://reviews.apache.org/r/54066/diff/
> 
> 
> Testing
> -------
> 
> Ran the q tests multiple times, since only the q tests and their output files were changed.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 54066: HIVE-15283: Index is dropped from wrong table in the index_auto_mult_tables.q and index_auto_mult_tables_compact.q tests

Posted by Peter Vary <pv...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54066/#review157013
-----------------------------------------------------------


Ship it!




LGTM (non binding)

Thanks for spotting this! :)

- Peter Vary


On Nov. 24, 2016, 3:59 p.m., Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54066/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 3:59 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Peter Vary, and Sergio Pena.
> 
> 
> Bugs: HIVE-15283
>     https://issues.apache.org/jira/browse/HIVE-15283
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changed the table name to srcpart in the "DROP INDEX srcpart_index_bitmap on src" and "DROP INDEX srcpart_index_compact on src" statements.
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables.q 823e373 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q fbb8720 
>   ql/src/test/results/clientpositive/index_auto_mult_tables.q.out a34654c 
>   ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 33a52ff 
> 
> Diff: https://reviews.apache.org/r/54066/diff/
> 
> 
> Testing
> -------
> 
> Ran the q tests multiple times, since only the q tests and their output files were changed.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 54066: HIVE-15283: Index is dropped from wrong table in the index_auto_mult_tables.q and index_auto_mult_tables_compact.q tests

Posted by Aihua Xu <ax...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54066/#review157249
-----------------------------------------------------------


Ship it!




Ship It!

- Aihua Xu


On Nov. 24, 2016, 3:59 p.m., Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54066/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 3:59 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Peter Vary, and Sergio Pena.
> 
> 
> Bugs: HIVE-15283
>     https://issues.apache.org/jira/browse/HIVE-15283
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changed the table name to srcpart in the "DROP INDEX srcpart_index_bitmap on src" and "DROP INDEX srcpart_index_compact on src" statements.
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables.q 823e373 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q fbb8720 
>   ql/src/test/results/clientpositive/index_auto_mult_tables.q.out a34654c 
>   ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 33a52ff 
> 
> Diff: https://reviews.apache.org/r/54066/diff/
> 
> 
> Testing
> -------
> 
> Ran the q tests multiple times, since only the q tests and their output files were changed.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>