You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:49:18 UTC

[GitHub] [arrow] andygrove opened a new pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

andygrove opened a new pull request #7853:
URL: https://github.com/apache/arrow/pull/7853


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-667122842


   @vertexclique Is working on a PR for this as well so I will likely close this one the new PR is up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-667207713


   Replaced by https://github.com/apache/arrow/pull/7874


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] paddyhoran commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
paddyhoran commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-665190021


   Looks fine to me.  Is it worth having `memory_used` (`len`) as well as `memory_size` (`capacity`)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove closed pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7853:
URL: https://github.com/apache/arrow/pull/7853


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-665038339


   @nevi-me @paddyhoran @sunchao does this general approach seem ok to you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-665042069


   https://issues.apache.org/jira/browse/ARROW-9582


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] sunchao commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-665193605


   Looks fine to me too. I also like `mem_used` or `memory_used` better but that is just a minor preference.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #7853: ARROW-9582: [Rust] Add memory_size() method to Array [DRAFT]

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #7853:
URL: https://github.com/apache/arrow/pull/7853#issuecomment-665068771


   > @nevi-me @paddyhoran @sunchao does this general approach seem ok to you?
   
   Hi Andy, yes it does to me


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org