You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/21 09:44:42 UTC
[GitHub] [kafka] dengziming opened a new pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0
dengziming opened a new pull request #10576:
URL: https://github.com/apache/kafka/pull/10576
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
#9622 add topicId in MetadataResponse and MetadataRequest, but describe topic using topicId is supported by #9769
sadly #9622 PR was merged but #9769 PR was held off, for more details: https://github.com/apache/kafka/pull/9769#issuecomment-772830472
I think this is a bug so we should fix this for 2.8.0.
This PR should be cherry-picked to 2.8.0.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10576:
URL: https://github.com/apache/kafka/pull/10576#issuecomment-824501282
@dengziming. I should have paid attention. I just saw this. I opened https://github.com/apache/kafka/pull/10584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10576:
URL: https://github.com/apache/kafka/pull/10576#issuecomment-825322789
Thank you @junrao @jolshan , move to #10584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan edited a comment on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0
Posted by GitBox <gi...@apache.org>.
jolshan edited a comment on pull request #10576:
URL: https://github.com/apache/kafka/pull/10576#issuecomment-824501282
@dengziming. I just saw this, so I didn't realize you were working on this too. I should have paid better attention. I opened https://github.com/apache/kafka/pull/10584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0
Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #10576:
URL: https://github.com/apache/kafka/pull/10576#issuecomment-824228739
@dengziming : We probably can't remove a field from an existing protocol without changing the version. Otherwise, the client will be confused on the exact protocol for a particular version. We could bump up the version (keeping all the fields the same) in 3.0 and implement the functionality for topicId there. For 2.8, we probably want to at least document in the protocol that topicId is not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming closed pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0
Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #10576:
URL: https://github.com/apache/kafka/pull/10576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org