You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by krskoondra <gi...@git.apache.org> on 2016/11/27 20:27:20 UTC

[GitHub] zeppelin pull request #1688: ZEPPELIN-1637 - Add button for "create next blo...

GitHub user krskoondra opened a pull request:

    https://github.com/apache/zeppelin/pull/1688

    ZEPPELIN-1637 - Add button for "create next block as copy of this block"

    ### What is this PR for?
    Added new buttton "Copy paragraph" near run button. This new button create copy of current paragraph and insert it below current paragraph.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1637
    
    ### How should this be tested?
    Write something into paragraph and click on button "Copy paragraph".
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/krskoondra/zeppelin iss1637

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1688
    
----
commit f6716e00fd2f3d657ccd4c46df34886401468f48
Author: Ond\u0159ej Kr\u0161ko <kr...@fel.cvut.cz>
Date:   2016-11-27T19:17:33Z

    ZEPPELIN-1637

commit 51165b89a1a6d1bcdbd16b50d94307b96835780a
Author: Ond\u0159ej Kr\u0161ko <kr...@fel.cvut.cz>
Date:   2016-11-27T20:08:37Z

    fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by krskoondra <gi...@git.apache.org>.

Github user krskoondra commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    OK, @Leemoonsoo, the button is now in the dropdown menu of the paragraph and new keyboard shortcut ctrl+shift+c is added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by krskoondra <gi...@git.apache.org>.

Github user krskoondra commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    @Leemoonsoo my id is krskoondra.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    @krskoondra Thanks for the nice feature.
    Merge to master if there're no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by krskoondra <gi...@git.apache.org>.

Github user krskoondra commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    Someone help me. How can I resolve "This branch has conflicts that must be resolved"?
    I'm beginner with opensorce and github.
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    @krskoondra Could you let me know you apache JIRA id? 
    so i can assign you in this https://issues.apache.org/jira/browse/ZEPPELIN-1637 issue and resolve.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    Thanks for updatding description! 
    Agree with @Leemoonsoo. And FYI, you can refer #1686 for assigning keyboard shortcut :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1688
  
    Thanks @krskoondra for the contribution.
    LGTM.
    
    merge to master if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---