[GitHub] [superset] villebro commented on a change in pull request #15942: feat(explore): Create new entrypoints for Echarts Timeseries

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #15942:
URL: https://github.com/apache/superset/pull/15942#discussion_r679044618



##########
File path: superset-frontend/src/visualizations/presets/MainPreset.js
##########
@@ -134,9 +141,33 @@ export default class MainPreset extends Preset {
         new TreemapChartPlugin().configure({ key: 'treemap' }),
         new WordCloudChartPlugin().configure({ key: 'word_cloud' }),
         new WorldMapChartPlugin().configure({ key: 'world_map' }),
+        new EchartsAreaChartPlugin().configure({
+          key: 'echarts_area',
+        }),
         new EchartsTimeseriesChartPlugin().configure({
           key: 'echarts_timeseries',
         }),
+        new EchartsTimeseriesBarChartPlugin().configure({
+          key: 'echarts_timeseries_bar',
+        }),
+        new EchartsTimeseriesLineChartPlugin().configure({
+          key: 'echarts_timeseries_line',
+        }),
+        new EchartsTimeseriesSmoothLineChartPlugin().configure({
+          key: 'echarts_timeseries_smooth',
+        }),
+        new EchartsTimeseriesScatterChartPlugin().configure({
+          key: 'echarts_timeseries_scatter',
+        }),
+        new EchartsTimeseriesStepStartChartPlugin().configure({
+          key: 'echarts_timeseries_step_start',
+        }),
+        new EchartsTimeseriesStepMiddleChartPlugin().configure({
+          key: 'echarts_timeseries_step_middle',
+        }),
+        new EchartsTimeseriesStepEndChartPlugin().configure({
+          key: 'echarts_timeseries_step_end',
+        }),

Review comment:
       I wonder if these should just collectively be `EchartsTimeseriesStepChartPlugin` with an additional control to define start/middle/end




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org