[GitHub] [shardingsphere] alonglee-cyber commented on issue #8778: ForceExecuteTemplate will hide the exception message when transaction rollback

[GitBox <gi...@apache.org>]

alonglee-cyber commented on issue #8778:
URL: https://github.com/apache/shardingsphere/issues/8778#issuecomment-762048890


   @yu199195 yes, i know it, the purpose of this is to recurrence exception.
   my mariadb cluster uses galera multimaster, deadlock happends occasionally.
   my problem is when deadlock happened, 
   logs of exception stack did not show message about the deadlock, only a message of null
   I can't tell from the log if it's a deadlock.
   
   logs looks like this:
   
   ```
   2021-01-14 12:13:24.148  WARN 1 --- [     Thread-115] c.s.e.r.handler.FreshRequestHandler      : handler request[6b39fe27-ebed-465f-94e2-f051e3506c0c@2021011412] error
   
   org.springframework.orm.jpa.JpaSystemException: Unable to commit against JDBC Connection; nested exception is org.hibernate.TransactionException: Unable to commit against JDBC Connection
   	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.convertHibernateAccessException(HibernateJpaDialect.java:353)
   	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.translateExceptionIfPossible(HibernateJpaDialect.java:255)
   	at org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:538)
   	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:743)
   	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
   	at com.sandstone.engine.service.PersistServiceImpl.saveRequest(PersistServiceImpl.java:77)
   	at com.sandstone.engine.request.event.RequestHandlerEventListener.requestStart(RequestHandlerEventListener.java:35)
   	at jdk.internal.reflect.GeneratedMethodAccessor124.invoke(Unknown Source)
   	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
   	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
   	at org.springframework.context.event.ApplicationListenerMethodAdapter.doInvoke(ApplicationListenerMethodAdapter.java:305)
   	at org.springframework.context.event.ApplicationListenerMethodAdapter.processEvent(ApplicationListenerMethodAdapter.java:190)
   	at org.springframework.transaction.event.ApplicationListenerMethodTransactionalAdapter.onApplicationEvent(ApplicationListenerMethodTransactionalAdapter.java:72)
   	at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172)
   	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165)
   	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
   	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:404)
   	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:361)
   	at com.sandstone.engine.request.handler.FreshRequestHandler.startRequest(FreshRequestHandler.java:123)
   	at com.sandstone.engine.request.handler.FreshRequestHandler.handle(FreshRequestHandler.java:151)
   	at com.sandstone.engine.request.handler.FreshRequestHandler.run(FreshRequestHandler.java:54)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   	at java.base/java.lang.Thread.run(Unknown Source)
   Caused by: org.hibernate.TransactionException: Unable to commit against JDBC Connection
   	at org.hibernate.resource.jdbc.internal.AbstractLogicalConnectionImplementor.commit(AbstractLogicalConnectionImplementor.java:92)
   	at org.hibernate.resource.transaction.backend.jdbc.internal.JdbcResourceLocalTransactionCoordinatorImpl$TransactionDriverControlImpl.commit(JdbcResourceLocalTransactionCoordinatorImpl.java:282)
   	at org.hibernate.engine.transaction.internal.TransactionImpl.commit(TransactionImpl.java:101)
   	at org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:534)
   	... 21 common frames omitted
   Caused by: java.sql.SQLException: null
   	at org.apache.shardingsphere.shardingjdbc.jdbc.adapter.executor.ForceExecuteTemplate.throwSQLExceptionIfNecessary(ForceExecuteTemplate.java:54)
   	at org.apache.shardingsphere.shardingjdbc.jdbc.adapter.executor.ForceExecuteTemplate.execute(ForceExecuteTemplate.java:47)
   	at org.apache.shardingsphere.shardingjdbc.jdbc.adapter.AbstractConnectionAdapter.commit(AbstractConnectionAdapter.java:172)
   	at org.apache.shardingsphere.shardingjdbc.jdbc.core.connection.ShardingConnection.commit(ShardingConnection.java:153)
   	at org.hibernate.resource.jdbc.internal.AbstractLogicalConnectionImplementor.commit(AbstractLogicalConnectionImplementor.java:86)
   	... 24 common frames omitted
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org