You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2006/04/19 15:57:34 UTC
[jira] Created: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Percent complete goes over 100% when installing configurations
--------------------------------------------------------------
Key: GERONIMO-1869
URL: http://issues.apache.org/jira/browse/GERONIMO-1869
Project: Geronimo
Type: Bug
Security: public (Regular issues)
Components: core
Versions: 1.1
Reporter: Aaron Mulder
Priority: Critical
Fix For: 1.1
Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=comments#action_12424961 ]
Aaron Mulder commented on GERONIMO-1869:
----------------------------------------
We have yet another problem with this issue, which is that packed artifacts should used the file size, whereas artifacts that are going to be unpacked should use the size of the contents.
Applied the ZipFile fix and a workaround that uses the unpacked size for UnpackArtifactTypeHandlers and packed size otherwise to 1.1.
Not applying to trunk because this really ought to be reconsidered in light of GERONIMO-2258 (if we're going to change the way we decide whether to unpack, we should also change when we do the size calculation so we only do it if we're going to unpack the artifact anyway).
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: core, console
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Priority: Critical
> Fix For: 1.1.x
>
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=all ]
Matt Hogstrom updated GERONIMO-1869:
------------------------------------
Fix Version: 1.1.1
(was: 1.1)
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: core
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Critical
> Fix For: 1.1.1
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-1869) Percent complete goes over 100% when
installing configurations
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=all ]
Aaron Mulder closed GERONIMO-1869.
----------------------------------
Fix Version/s: 1.1.1
(was: 1.1.x)
Resolution: Fixed
Assignee: Aaron Mulder
Closing as fixed in 1.1.1. Created a copy of this issue to track it in trunk.
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: core, console
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: Aaron Mulder
> Priority: Critical
> Fix For: 1.1.1
>
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=all ]
Aaron Mulder reassigned GERONIMO-1869:
--------------------------------------
Assign To: Aaron Mulder
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: core
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Critical
> Fix For: 1.1
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Posted by "Alan Cabrera (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=all ]
Alan Cabrera updated GERONIMO-1869:
-----------------------------------
Fix Version/s: 1.1.x
(was: 1.1.1)
Moving unassigned issues over to the 1.1.x pool where they can be worked on for the, in all probability, 1.1.2 patch.
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: core
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Priority: Critical
> Fix For: 1.1.x
>
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=all ]
Aaron Mulder updated GERONIMO-1869:
-----------------------------------
Component/s: console
Someone put in a partial fix for this (when installing from file into repository, but not when installing from stream into repository).
However, I have a couple issues with the fix -- it opened a ZipFile but never closed it (meaning the file is locked for the duration of the JVM), and it tried to open the file as a ZipFile and catch an exception as a method of determining whether it was in fact a ZipFile. I will fix this, but we still need to think about how to handle the stream issue.
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: core, console
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Priority: Critical
> Fix For: 1.1.x
>
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1869) Percent complete goes over 100%
when installing configurations
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1869?page=all ]
Aaron Mulder updated GERONIMO-1869:
-----------------------------------
Assign To: (was: Aaron Mulder)
> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
> Key: GERONIMO-1869
> URL: http://issues.apache.org/jira/browse/GERONIMO-1869
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: core
> Versions: 1.1
> Reporter: Aaron Mulder
> Priority: Critical
> Fix For: 1.1.1
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).
> Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira