You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/17 09:59:07 UTC
[GitHub] [camel-spring-boot] JiriOndrusek opened a new pull request #472: CAMEL-17800 add tests in camel-sql-starter
JiriOndrusek opened a new pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472
Issue: https://issues.apache.org/jira/browse/CAMEL-17800
Here is list of migrated tests according to the sql component [doc](https://camel.apache.org/components/3.15.x/sql-component.html):
- `Treatment of the message body` in `SqlProducerUseMessageBodyForSqlTest`
- `Result of the query` in `SqlProducerUseMessageBodyForSqlTest`
- `Using StreamList` in `SqlProducerOutputTypeStreamListTest`
- `Header values` in `SqlProducerUpdateHeadersTest`
- `Generated keys` in `SqlGeneratedKeysTest`
- `DataSource` in `SqlEndpointMisconfigureDataSourceTest`
- `Using named parameters` in `SqlProducerToDTest`
- `Using expression parameters in producers` in `SqlProducerExpressionParameterTest`
- `Using expression parameters in consumers` in `SqlConsumerDynamicParameterTest`
- ` Using IN queries with dynamic values` in `SqlProducerInTest`
- `Using the JDBC based idempotent repository` in ` JdbcMessageIdRepositoryTest`
- `Customize the JDBC idempotency repository` in `CustomizedJdbcMessageIdRepositoryTest`
- `Orphan Lock aware Jdbc IdempotentRepository` in `JdbcOrphanLockAwareIdempotentRepositoryTest`
- `Caching Jdbc IdempotentRepository` in `JdbcCachedMessageIdRepositoryTest`
- `Using the JDBC based aggregation repository` in `JdbcAggregateRecoverDeadLetterChannelTest`, `JdbcAggregateRecoverDeadLetterChannelTest`, `JdbcAggregateStoreAsTextTest`, `JdbcAggregateSerializedHeadersTest`
- `Transaction` in `SqlTransactedRouteTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] JiriOndrusek commented on pull request #472: CAMEL-17800 add tests in camel-sql-starter
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472#issuecomment-1072360153
I understand that there is a lot of copy/paste stuff. Unfortunately this is the only approach I see possible for this case. Here are some facts:
- Tests in camel-sql-starter don't aim to get whole coverage as tests from component itself. Ii's a mere a selection from the tests to cover main "chapters" from the documentation.
- Even if tests are similar, there is a lot of changes in the code (different approach for configuring routes, different parents, making beans auowirable, ...)
- from my POV starter tests could be "modified" much more. But I kept the names of classes and test methods for the future for easier determination from with base test it was created. Also to keep consistency with other starters (see for example https://github.com/apache/camel-spring-boot/commit/8e926a2cf299a2ce68be7904089e324366553167, https://github.com/apache/camel-spring-boot/commit/f167f458464a244bab5fcbc465212e3bbbcad0e7, https://github.com/apache/camel-spring-boot/commit/7860fca6ce1213ffd7f01d027e5ea65d3c46346f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus merged pull request #472: CAMEL-17800 add tests in camel-sql-starter
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] orpiske commented on pull request #472: CAMEL-17800 add tests in camel-sql-starter
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472#issuecomment-1070957527
Just out of curiosity - and I apologize because I am not knowledgeable about Spring boot at all - but wouldn't it be easier to maintain these tests by modifying Camel test code to package the tests jar and then extending them here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] orpiske commented on pull request #472: CAMEL-17800 add tests in camel-sql-starter
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472#issuecomment-1072390433
> I understand that there is a lot of copy/paste stuff. Unfortunately this is the only approach I see possible for this case. Here are some facts:
>
> * Tests in camel-sql-starter don't aim to get whole coverage as tests from component itself. Ii's a mere a selection from the tests to cover main "chapters" from the documentation.
>
> * Even if tests are similar, there is a lot of changes in the code (different approach for configuring routes, different parents, making beans auowirable, ...)
>
> * from my POV starter tests could be "modified" much more. But I kept the names of classes and test methods for the future for easier determination from with base test it was created. Also to keep consistency with other starters (see for example [8e926a2](https://github.com/apache/camel-spring-boot/commit/8e926a2cf299a2ce68be7904089e324366553167), [f167f45](https://github.com/apache/camel-spring-boot/commit/f167f458464a244bab5fcbc465212e3bbbcad0e7), [7860fca](https://github.com/apache/camel-spring-boot/commit/7860fca6ce1213ffd7f01d027e5ea65d3c46346f))
Ahh, I see. Thanks for the heads up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] orpiske commented on pull request #472: CAMEL-17800 add tests in camel-sql-starter
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472#issuecomment-1070957527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] JiriOndrusek commented on pull request #472: CAMEL-17800 add tests in camel-sql-starter
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #472:
URL: https://github.com/apache/camel-spring-boot/pull/472#issuecomment-1072360153
I understand that there is a lot of copy/paste stuff. Unfortunately this is the only approach I see possible for this case. Here are some facts:
- Tests in camel-sql-starter don't aim to get whole coverage as tests from component itself. Ii's a mere a selection from the tests to cover main "chapters" from the documentation.
- Even if tests are similar, there is a lot of changes in the code (different approach for configuring routes, different parents, making beans auowirable, ...)
- from my POV starter tests could be "modified" much more. But I kept the names of classes and test methods for the future for easier determination from with base test it was created. Also to keep consistency with other starters (see for example https://github.com/apache/camel-spring-boot/commit/8e926a2cf299a2ce68be7904089e324366553167, https://github.com/apache/camel-spring-boot/commit/f167f458464a244bab5fcbc465212e3bbbcad0e7, https://github.com/apache/camel-spring-boot/commit/7860fca6ce1213ffd7f01d027e5ea65d3c46346f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org