You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/12 22:31:03 UTC
[jira] [Commented] (FLINK-7521) Remove the 10MB limit from the
current REST implementation.
[ https://issues.apache.org/jira/browse/FLINK-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396188#comment-16396188 ]
ASF GitHub Bot commented on FLINK-7521:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5685
[FLINK-7521][flip6]
## What is the purpose of the change
*Make HTTP request and response limits configurable. A relatively high default value is chosen (100 mb) because Netty does not allocate the upper limit at once.*
## Brief change log
- *Make HTTP request and response limits configurable.*
## Verifying this change
This change added tests and can be verified as follows:
- *Added tests to `RestServerEndpointITCase`*
- *Manually verified that client and server limits are respected.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-7521-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5685
----
commit aef8fa247a4c8b14f4dd7ce8f324ccd89bb2ce14
Author: zjureel <zj...@...>
Date: 2017-09-07T02:39:39Z
[FLINK-7521] Add config option to set the content length limit of REST server and client
commit ff6c7eb1127ff1870f479c1b779379cc22c9dc87
Author: gyao <ga...@...>
Date: 2018-03-12T14:44:27Z
[FLINK-7521][flip6] Remove RestServerEndpoint#MAX_REQUEST_SIZE_BYTES
commit a14e5935dd9132ddb43e55e357674d390ff9c597
Author: gyao <ga...@...>
Date: 2018-03-12T22:16:25Z
[FLINK-7521][flip6] Return HTTP 413 if request limit is exceeded.
Remove unnecessary PipelineErrorHandler from RestClient.
Rename config keys for configuring request and response limits.
Set response headers for all error responses.
----
> Remove the 10MB limit from the current REST implementation.
> -----------------------------------------------------------
>
> Key: FLINK-7521
> URL: https://issues.apache.org/jira/browse/FLINK-7521
> Project: Flink
> Issue Type: Improvement
> Components: REST
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Kostas Kloudas
> Assignee: Gary Yao
> Priority: Blocker
> Labels: flip6
> Fix For: 1.5.0
>
>
> In the current {{AbstractRestServer}} we impose an upper bound of 10MB in the states we can transfer. This is in the line {{.addLast(new HttpObjectAggregator(1024 * 1024 * 10))}} of the server implementation.
> This limit is restrictive for some of the usecases planned to use this implementation (e.g. the job submission client which has to send full jars, or the queryable state client which may have to receive states bigger than that).
> This issue proposes the elimination of this limit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)