You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/08/09 15:00:44 UTC
Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/
-----------------------------------------------------------
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-3850
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
Diff: https://reviews.apache.org/r/13441/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On Aug. 10, 2013, 1:11 p.m., Koushik Das wrote:
> > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java, line 663
> > <https://reviews.apache.org/r/13441/diff/1/?file=339183#file339183line663>
> >
> > CPU weight computation is not considering the number of CPUs in the VM but utilization is considering it. Shouldn't both follow the same logic? If not can you explain the logic and put a comment in the code for the same.
> >
> > Also what is logic for multiplying the speed with 0.99?
This is as per the design of xenserver.
CPU weight is calculated per VCPU. So whatever the weight we assign Xenserver allocates to each VCPU and cpu cap is per VM.
Please refer
For CPU Weight: http://blog.xen.org/index.php/2010/08/13/rfc-credit1-make-weight-per-vcpu/
For CPU cap: http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201206.mbox/%3CB1DF26ECC0458748AC97CECE2DA98D41012F9D61ADA0@SJCPMAILBOX01.citrite.net%3E
Multiplication with 0.99 is what we follow during vm deployment may be for some overhead calculations, So It should be the same during scale vm also.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/#review24968
-----------------------------------------------------------
On Aug. 9, 2013, 1 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13441/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 1 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-3850
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
>
> Diff: https://reviews.apache.org/r/13441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/#review24968
-----------------------------------------------------------
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/13441/#comment49132>
CPU weight computation is not considering the number of CPUs in the VM but utilization is considering it. Shouldn't both follow the same logic? If not can you explain the logic and put a comment in the code for the same.
Also what is logic for multiplying the speed with 0.99?
- Koushik Das
On Aug. 9, 2013, 1 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13441/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 1 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-3850
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
>
> Diff: https://reviews.apache.org/r/13441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/#review24974
-----------------------------------------------------------
'mvn clean install' on 4.2 branch resulted in build failure. XS unit test is failing.
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache CloudStack Plugin - Hypervisor Xen 4.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-xen ---
[INFO] Deleting /Users/koushik/code/cloudstack-apache/cloudstack/plugins/hypervisors/xen/target (includes = [**/*], excludes = [])
[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-hypervisor-xen ---
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/koushik/code/cloudstack-apache/cloudstack/plugins/hypervisors/xen/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-plugin-hypervisor-xen ---
[INFO] Compiling 19 source files to /Users/koushik/code/cloudstack-apache/cloudstack/plugins/hypervisors/xen/target/classes
[WARNING] Unable to autodetect 'javac' path, using 'javac' from the environment.
[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/koushik/code/cloudstack-apache/cloudstack/plugins/hypervisors/xen/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-plugin-hypervisor-xen ---
[INFO] Compiling 1 source file to /Users/koushik/code/cloudstack-apache/cloudstack/plugins/hypervisors/xen/target/test-classes
[WARNING] Unable to autodetect 'javac' path, using 'javac' from the environment.
[INFO]
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-plugin-hypervisor-xen ---
[INFO] Surefire report directory: /Users/koushik/code/cloudstack-apache/cloudstack/plugins/hypervisors/xen/target/surefire-reports
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running com.cloud.hypervisor.xen.resource.CitrixResourceBaseTest
log4j:WARN No appenders could be found for logger (com.cloud.hypervisor.xen.resource.XenServerConnectionPool).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.884 sec <<< FAILURE!
Results :
Failed tests: testScaleVMF3(com.cloud.hypervisor.xen.resource.CitrixResourceBaseTest): (..)
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
- Koushik Das
On Aug. 10, 2013, 7:08 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13441/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 7:08 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-3850
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
>
> Diff: https://reviews.apache.org/r/13441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/#review24978
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On Aug. 11, 2013, 5:28 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13441/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2013, 5:28 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-3850
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
> plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java cb16ae2
>
> Diff: https://reviews.apache.org/r/13441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/#review24979
-----------------------------------------------------------
Commit 726114a95df0c0525617225e07295b8dff10a8af in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=726114a ]
CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
Signed-off-by: Koushik Das <ko...@apache.org>
- ASF Subversion and Git Services
On Aug. 11, 2013, 5:28 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13441/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2013, 5:28 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-3850
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
> plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java cb16ae2
>
> Diff: https://reviews.apache.org/r/13441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/#review24977
-----------------------------------------------------------
Commit a7dea8eecdee071e09cc90d6e7e47c8b93746bb1 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a7dea8e ]
CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
Signed-off-by: Koushik Das <ko...@apache.org>
- ASF Subversion and Git Services
On Aug. 11, 2013, 5:28 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13441/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2013, 5:28 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-3850
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
> plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java cb16ae2
>
> Diff: https://reviews.apache.org/r/13441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/
-----------------------------------------------------------
(Updated Aug. 11, 2013, 5:28 p.m.)
Review request for cloudstack and Koushik Das.
Changes
-------
added unit test changes
Bugs: CLOUDSTACK-3850
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
Diffs (updated)
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java cb16ae2
Diff: https://reviews.apache.org/r/13441/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per
VCPU
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13441/
-----------------------------------------------------------
(Updated Aug. 10, 2013, 7:08 p.m.)
Review request for cloudstack and Koushik Das.
Changes
-------
updated patch.(added comments)
Bugs: CLOUDSTACK-3850
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
Diffs (updated)
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1
Diff: https://reviews.apache.org/r/13441/diff/
Testing
-------
Thanks,
Harikrishna Patnala