You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Moelf (via GitHub)" <gi...@apache.org> on 2023/04/11 16:11:58 UTC
[GitHub] [arrow-julia] Moelf opened a new pull request, #424: add dev CI for monorepo
Moelf opened a new pull request, #424:
URL: https://github.com/apache/arrow-julia/pull/424
@ericphanson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1505919364
can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503916641
ah, it's the `continue-on-error`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503974565
finally!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] baumgold commented on pull request #424: add dev CI for monorepo
Posted by "baumgold (via GitHub)" <gi...@apache.org>.
baumgold commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503770905
> https://github.com/apache/arrow-julia/actions/runs/4669945251/jobs/8269066505#step:6:166
>
> wait it errored but didn't fail CI? and also, why would this error??
#390 was merged but still not released. #407 for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503777216
this is checking out the source code for both packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503808243
need more workflow approval..........
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] kou commented on a diff in pull request #424: add dev CI for monorepo
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#discussion_r1163638230
##########
.github/workflows/ci.yml:
##########
@@ -105,6 +105,43 @@ jobs:
- uses: codecov/codecov-action@v1
with:
file: lcov.info
+ test_monorepo:
+ name: Monorepo dev - Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: true
+ matrix:
+ version:
+ - '1' # automatically expands to the latest stable 1.x release of Julia
+ os:
+ - ubuntu-latest
+ arch:
+ - x64
+ steps:
+ - uses: actions/checkout@v2
+ - uses: julia-actions/setup-julia@v1
+ with:
+ version: ${{ matrix.version }}
+ arch: ${{ matrix.arch }}
+ - uses: actions/cache@v1
Review Comment:
```suggestion
- uses: actions/cache@v3
```
##########
.github/workflows/ci.yml:
##########
@@ -105,6 +105,43 @@ jobs:
- uses: codecov/codecov-action@v1
with:
file: lcov.info
+ test_monorepo:
+ name: Monorepo dev - Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: true
+ matrix:
+ version:
+ - '1' # automatically expands to the latest stable 1.x release of Julia
+ os:
+ - ubuntu-latest
+ arch:
+ - x64
+ steps:
+ - uses: actions/checkout@v2
Review Comment:
```suggestion
- uses: actions/checkout@v3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] ericphanson commented on pull request #424: add dev CI for monorepo
Posted by "ericphanson (via GitHub)" <gi...@apache.org>.
ericphanson commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1504159797
Great, I see ArrowTypes see failing, monorepo CI failing, release CI failing, but Arrow.jl CI passing, as expected. Ok go ahead and remove the test error and we can merge IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1505483469
@kou do it if you want I don't have a day I just want to run my CI in a different PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] ericphanson commented on pull request #424: add dev CI for monorepo
Posted by "ericphanson (via GitHub)" <gi...@apache.org>.
ericphanson commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503905350
I think maybe this should be an entirely separate workflow file. Because the situation in #419 is that it works when you use them together, but fails when used release-vs-dev versions, because you're updating them in tandem. So with `fast-fail:true` we will only see one of those things, not both. And it seems `fast-fail: false` is problematic bc it shows stuff as passing when it isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] kou merged pull request #424: add dev CI for monorepo
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #424:
URL: https://github.com/apache/arrow-julia/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] ericphanson commented on pull request #424: add dev CI for monorepo
Posted by "ericphanson (via GitHub)" <gi...@apache.org>.
ericphanson commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503896473
Do we understand why https://github.com/apache/arrow-julia/pull/424#issuecomment-1503762574 happened? Seems bad if tests fail but CI passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] ericphanson commented on pull request #424: add dev CI for monorepo
Posted by "ericphanson (via GitHub)" <gi...@apache.org>.
ericphanson commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503980052
np, thanks for your persistence. Can we verify the failure mode here? E.g. put an `error()` in an ArrowTypes function (or even `__init__() = error()` in ArrowTypes), so we can see the expected workflows pass/fail. In that case we should expect: Arrow.jl tests to pass (uses release ArrowTypes module), ArrowTypes to fail (uses dev version) and monorepo tests to fail (uses dev version). We can verify we get the appropriate ❌ here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] kou commented on pull request #424: add dev CI for monorepo
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1505982261
Ah, sorry. I should have said explicitly that Dependabot should be done as a follow-up PR not in this PR.
Creating a new issue for it is enough for now.
(If we don't need Dependabot, we don't need to do anything.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #424: add dev CI for monorepo
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503786916
## [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#424](https://codecov.io/gh/apache/arrow-julia/pull/424?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e367d1) into [main](https://codecov.io/gh/apache/arrow-julia/commit/22088f1cb59bcd99fbffbf9d8248e491690dbfd9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22088f1) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 3e367d1 differs from pull request most recent head d0ac65c. Consider uploading reports for the commit d0ac65c to get more accurate results
```diff
@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 26 26
Lines 3259 3259
=======================================
Hits 2834 2834
Misses 425 425
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503913109
mv, somehow it still passed CI https://github.com/apache/arrow-julia/actions/runs/4670924052/jobs/8271270779#step:6:165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] ericphanson commented on a diff in pull request #424: add dev CI for monorepo
Posted by "ericphanson (via GitHub)" <gi...@apache.org>.
ericphanson commented on code in PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#discussion_r1163192249
##########
Project.toml:
##########
@@ -64,4 +64,5 @@ TOML = "fa267f1f-6049-4f14-aa54-33bafae1ed76"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
[targets]
-test = ["CategoricalArrays", "DataFrames", "FilePathsBase", "JSON3", "Random", "StructTypes", "TOML", "Test"]
+test = ["CategoricalArrays", "DataFrames", "FilePathsBase", "JSON3", "Random", "StructTypes",
+"TOML", "Test", "Sockets"]
Review Comment:
`Socket` should be under `[extras]` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503907678
the `fast-fail` only apply to `ci - monorepo`, it does not affect other step like `test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503898969
that is fixed now with `fast-fail`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503789357
ok, it's because the test is directly including `test.jl` from ArrowTypes, which bypassed the `using Sockets` in `runtests.jl`
added now directly in Arrow.jl's `runtests.jl` as we do for UUID already
tbh I don't understand why the tests are so messy here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503981446
this should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] ericphanson commented on a diff in pull request #424: add dev CI for monorepo
Posted by "ericphanson (via GitHub)" <gi...@apache.org>.
ericphanson commented on code in PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#discussion_r1163080668
##########
.github/workflows/ci.yml:
##########
@@ -105,6 +105,43 @@ jobs:
- uses: codecov/codecov-action@v1
with:
file: lcov.info
+ test_monorepo:
+ name: Monorepo dev - Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ version:
+ - '1' # automatically expands to the latest stable 1.x release of Julia
+ os:
+ - ubuntu-latest
+ arch:
+ - x64
+ steps:
+ - uses: actions/checkout@v2
+ - uses: julia-actions/setup-julia@v1
+ with:
+ version: ${{ matrix.version }}
+ arch: ${{ matrix.arch }}
+ - uses: actions/cache@v1
+ env:
+ cache-name: cache-artifacts
+ with:
+ path: ~/.julia/artifacts
+ key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
+ restore-keys: |
+ ${{ runner.os }}-test-${{ env.cache-name }}-
+ ${{ runner.os }}-test-
+ ${{ runner.os }}-
+ - name: Dev monorepo dependencies
+ shell: julia --project=monorepo {0}
+ run: |
+ using Pkg;
+ pkg"dev . ./ArrowTypes"
Review Comment:
better to use the API, and also the path is in `src`:
```suggestion
Pkg.develop([PackageSpec(path="."), PackageSpec(path="src/ArrowTypes")])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] Moelf commented on pull request #424: add dev CI for monorepo
Posted by "Moelf (via GitHub)" <gi...@apache.org>.
Moelf commented on PR #424:
URL: https://github.com/apache/arrow-julia/pull/424#issuecomment-1503762574
https://github.com/apache/arrow-julia/actions/runs/4669945251/jobs/8269066505#step:6:166
wait it errored but didn't fail CI? and also, why would this error??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org