[GitHub] [doris] zhengshiJ commented on a diff in pull request #12583: [feature](Nereids) implement grouping sets

[GitBox <gi...@apache.org>]

zhengshiJ commented on code in PR #12583:
URL: https://github.com/apache/doris/pull/12583#discussion_r1003209193


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildOutputPropertyDeriver.java:
##########
@@ -87,6 +89,18 @@ public PhysicalProperties visitPhysicalAggregate(PhysicalAggregate<? extends Pla
         }
     }
 
+    @Override
+    public PhysicalProperties visitPhysicalGroupBy(PhysicalGroupBy<? extends Plan> groupBy, PlanContext context) {

Review Comment:
   @morrySnow Please help to see if this is correct



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/RequestPropertyDeriver.java:
##########
@@ -113,6 +114,12 @@ public Void visitPhysicalAggregate(PhysicalAggregate<? extends Plan> agg, PlanCo
         // TODO: add other phase logical when we support distinct aggregate
     }
 
+    @Override
+    public Void visitPhysicalGroupBy(PhysicalGroupBy<? extends Plan> groupBy, PlanContext context) {

Review Comment:
   @morrySnow Please help to see if this is correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org