You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/12/10 05:34:47 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3377: ARTEMIS-3026 Allow "re-encode" of amqp large messages

clebertsuconic commented on a change in pull request #3377:
URL: https://github.com/apache/activemq-artemis/pull/3377#discussion_r539857580



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java
##########
@@ -622,7 +624,15 @@ public long getPersistentSize() throws ActiveMQException {
 
    @Override
    public void reencode() {
+      reEncoded = true;

Review comment:
       It would be fairly difficult to re-encode the message on the large message file.
   For AMQP Large messages, I'm instead just flagging the message as re-encoded, and I would replace the stream during the delivery.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org