[GitHub] [pinot] nizarhejazi commented on pull request #8468: Support Single-valued BigDecimal columns across different SQL statements, and Pinot transforms and operators

[GitBox <gi...@apache.org>]

nizarhejazi commented on PR #8468:
URL: https://github.com/apache/pinot/pull/8468#issuecomment-1089563906

   > Not really sure if we need to implement `transformToBigDecimalValuesSV` in all the functions. We can use `transformToBytesValuesSV` I think
   
   - Operations on BigDecimals are in most cases not equivalent to the same operation on the byte[] representation of these big decimals.
   - We need to use Presto on top of Pinot and we cannot apply BigDecimalUtils.deserialize/serialize everywhere we work with Decimals. We generate Presto SQL and this gets translated into Pinot.
   - There are places (not visible in the SQL query) where dealing with BigDecimals is needed for producing correct results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org