You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/01 16:16:52 UTC

[GitHub] [incubator-doris] morningman commented on a diff in pull request #9927: [fix] (planner) slot nullable is not set correctly when plan outer join with inline view

morningman commented on code in PR #9927:
URL: https://github.com/apache/incubator-doris/pull/9927#discussion_r886995035


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/InlineViewRef.java:
##########
@@ -207,7 +207,16 @@ public void analyze(Analyzer analyzer) throws AnalysisException, UserException {
             materializedTupleIds.add(desc.getId());
         }
 
-        // create smap_ and baseTblSmap_ and register auxiliary eq predicates between our
+        // anlayzeLateralViewRefs
+        analyzeLateralViewRef(analyzer);
+
+        // We need to analyze join behind create sMap and baseTblSmap, because SlotDescriptors of inline view's

Review Comment:
   ```suggestion
           // We need to analyze join before create sMap and baseTblSmap, because SlotDescriptors of inline view's
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org