You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/02/24 11:43:29 UTC
[Impala-ASF-CR](2.x) [DOCS] Corrected the supported values for parquet array resolution
Hello Alex Rodoni, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12571
to review the following change.
Change subject: [DOCS] Corrected the supported values for parquet_array_resolution
......................................................................
[DOCS] Corrected the supported values for parquet_array_resolution
Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Cherry-pick the following commit first, otherwise the doc doesn't exist.
I have change the description of the default value that
PARQUET_ARRAY_RESOLUTION defaults to TWO_LEVEL_THEN_THREE_LEVEL in 2.x.
IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option
Cherry-picks: not for 2.x
Change-Id: I12696b609609ea16c05d8b7e84b2bae0be6d6cb5
Reviewed-on: http://gerrit.cloudera.org:8080/9534
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
[DOCS] Corrected the supported values for parquet_array_resolution
Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Reviewed-on: http://gerrit.cloudera.org:8080/10840
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
A docs/topics/impala_parquet_array_resolution.xml
3 files changed, 209 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/12571/1
--
To view, visit http://gerrit.cloudera.org:8080/12571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) [DOCS] Corrected the supported values for parquet array resolution
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12571 )
Change subject: [DOCS] Corrected the supported values for parquet_array_resolution
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12571/1/docs/topics/impala_parquet_array_resolution.xml
File docs/topics/impala_parquet_array_resolution.xml:
http://gerrit.cloudera.org:8080/#/c/12571/1/docs/topics/impala_parquet_array_resolution.xml@57
PS1, Line 57: PARQUET_ARRAY_RESOLTUTION
This is a typo but a later commit fixes it.
--
To view, visit http://gerrit.cloudera.org:8080/12571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Feb 2019 23:30:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) [DOCS] Corrected the supported values for parquet array resolution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12571 )
Change subject: [DOCS] Corrected the supported values for parquet_array_resolution
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/234/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 12:00:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Corrected the supported values for parquet array resolution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12571 )
Change subject: [DOCS] Corrected the supported values for parquet_array_resolution
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/234/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 11:43:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Corrected the supported values for parquet array resolution
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12571 )
Change subject: [DOCS] Corrected the supported values for parquet_array_resolution
......................................................................
Patch Set 2:
(1 comment)
Thanks, Tim!
http://gerrit.cloudera.org:8080/#/c/12571/1/docs/topics/impala_parquet_array_resolution.xml
File docs/topics/impala_parquet_array_resolution.xml:
http://gerrit.cloudera.org:8080/#/c/12571/1/docs/topics/impala_parquet_array_resolution.xml@57
PS1, Line 57: PARQUET_ARRAY_RESOLTUTION
> This is a typo but a later commit fixes it.
Good to know this :)
--
To view, visit http://gerrit.cloudera.org:8080/12571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Feb 2019 23:38:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) [DOCS] Corrected the supported values for parquet array resolution
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12571 )
Change subject: [DOCS] Corrected the supported values for parquet_array_resolution
......................................................................
[DOCS] Corrected the supported values for parquet_array_resolution
Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Cherry-pick the following commit first, otherwise the doc doesn't exist.
I have change the description of the default value that
PARQUET_ARRAY_RESOLUTION defaults to TWO_LEVEL_THEN_THREE_LEVEL in 2.x.
IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option
Cherry-picks: not for 2.x
Change-Id: I12696b609609ea16c05d8b7e84b2bae0be6d6cb5
Reviewed-on: http://gerrit.cloudera.org:8080/9534
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
[DOCS] Corrected the supported values for parquet_array_resolution
Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Reviewed-on: http://gerrit.cloudera.org:8080/10840
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12571
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
A docs/topics/impala_parquet_array_resolution.xml
3 files changed, 209 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfc1b7209d0f6b28c814be4149b0bacfebad2356
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>