You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2023/01/14 07:36:43 UTC
[GitHub] [shenyu] tian-pengfei opened a new pull request, #4316: Fixed compatibility of Sign of 2.5.0 version
tian-pengfei opened a new pull request, #4316:
URL: https://github.com/apache/shenyu/pull/4316
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4316: Fixed compatibility of Sign-Plugin of 2.5.0 version
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #4316:
URL: https://github.com/apache/shenyu/pull/4316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei commented on pull request #4316: Fixed compatibility of Sign-Plugin of 2.5.0 version
Posted by GitBox <gi...@apache.org>.
tian-pengfei commented on PR #4316:
URL: https://github.com/apache/shenyu/pull/4316#issuecomment-1382697071
@yu199195 Hi Please Review ,I will finish Documentation tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei commented on pull request #4316: Fixed compatibility of Sign-Plugin of 2.5.0 version
Posted by GitBox <gi...@apache.org>.
tian-pengfei commented on PR #4316:
URL: https://github.com/apache/shenyu/pull/4316#issuecomment-1383520664
> @yu199195 Hi Please Review ,I will finish Documentation tomorrow. Thanks
apache/shenyu-website#848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4316: Fixed compatibility of Sign-Plugin of 2.5.0 version
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4316:
URL: https://github.com/apache/shenyu/pull/4316#issuecomment-1382686266
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4316](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9be9398) into [master](https://codecov.io/gh/apache/shenyu/commit/9f98261107f7f9927c39a0a34df4c7d0d5b1e97c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f98261) will **decrease** coverage by `0.02%`.
> The diff coverage is `91.78%`.
> :exclamation: Current head 9be9398 differs from pull request most recent head d19485e. Consider uploading reports for the commit d19485e to get more accurate results
```diff
@@ Coverage Diff @@
## master #4316 +/- ##
============================================
- Coverage 68.00% 67.97% -0.03%
- Complexity 7462 7474 +12
============================================
Files 1015 1019 +4
Lines 28745 28784 +39
Branches 2575 2574 -1
============================================
+ Hits 19548 19567 +19
- Misses 7670 7684 +14
- Partials 1527 1533 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nyu/plugin/sign/service/ComposableSignService.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0NvbXBvc2FibGVTaWduU2VydmljZS5qYXZh) | `92.64% <ø> (+1.47%)` | :arrow_up: |
| [...shenyu/plugin/sign/extractor/DefaultExtractor.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9leHRyYWN0b3IvRGVmYXVsdEV4dHJhY3Rvci5qYXZh) | `60.00% <55.55%> (-33.34%)` | :arrow_down: |
| [...nyu/plugin/sign/extractor/VersionTwoExtractor.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9leHRyYWN0b3IvVmVyc2lvblR3b0V4dHJhY3Rvci5qYXZh) | `93.33% <93.33%> (ø)` | |
| [...u/plugin/sign/provider/VersionOneSignProvider.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9wcm92aWRlci9WZXJzaW9uT25lU2lnblByb3ZpZGVyLmphdmE=) | `95.83% <95.83%> (ø)` | |
| [.../apache/shenyu/plugin/sign/api/SignParameters.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2lnblBhcmFtZXRlcnMuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...nyu/plugin/sign/extractor/VersionOneExtractor.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9leHRyYWN0b3IvVmVyc2lvbk9uZUV4dHJhY3Rvci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...enyu/plugin/sign/provider/DefaultSignProvider.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9wcm92aWRlci9EZWZhdWx0U2lnblByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...u/plugin/sign/provider/VersionTwoSignProvider.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9wcm92aWRlci9WZXJzaW9uVHdvU2lnblByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `68.96% <0.00%> (-13.80%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `81.63% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/shenyu/pull/4316?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org