You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/17 08:17:23 UTC
[GitHub] [hive] ArkoSharma opened a new pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
ArkoSharma opened a new pull request #1988:
URL: https://github.com/apache/hive/pull/1988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r578161679
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -131,7 +131,8 @@ private void loadDumpFromFile() throws SemanticException {
lineContents[2].equals(Utilities.nullStringOutput) ? null : Long.valueOf(lineContents[2]),
lineContents[3].equals(Utilities.nullStringOutput) ? null : new Path(lineContents[3]),
lineContents[4].equals(Utilities.nullStringOutput) ? null : Long.valueOf(lineContents[4]),
- Boolean.valueOf(lineContents[6]));
+ (lineContents.length < 8 || lineContents[6].equals(Utilities.nullStringOutput)) ?
Review comment:
check for length < 7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r591047351
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -203,7 +204,7 @@ private void initializeIfNot() throws SemanticException {
}
}
- private List<String> prepareReplScopeValues() {
+ public List<String> prepareReplScopeValues() {
Review comment:
Done to give access to this function from the unit-test (testDumpMetadataBackwardCompatibility). This function is required to create the repl-scope values during dump. So, during the test, while re-creating the dmd file in the same manner, this function is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha merged pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
Posted by GitBox <gi...@apache.org>.
aasha merged pull request #1988:
URL: https://github.com/apache/hive/pull/1988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r591034982
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -203,7 +204,7 @@ private void initializeIfNot() throws SemanticException {
}
}
- private List<String> prepareReplScopeValues() {
+ public List<String> prepareReplScopeValues() {
Review comment:
why is this needed?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -38,7 +38,7 @@
public class DumpMetaData {
// wrapper class for reading and writing metadata about a dump
// responsible for _dumpmetadata files
- private static final String DUMP_METADATA = "_dumpmetadata";
+ public static final String DUMP_METADATA = "_dumpmetadata";
Review comment:
why is this needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r591042930
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -38,7 +38,7 @@
public class DumpMetaData {
// wrapper class for reading and writing metadata about a dump
// responsible for _dumpmetadata files
- private static final String DUMP_METADATA = "_dumpmetadata";
+ public static final String DUMP_METADATA = "_dumpmetadata";
Review comment:
The test for this patch (testDumpMetadataBackwardCompatibility) needs to probe on the dumpmetadata file.
The test works by doing a dump, then deleting newly introduced fields from the dumpmetadata file and then doing a load. This change was made to provide access to the dmd-file name to the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1988: HIVE-24791: Backward compatibility issue in _dumpmetadata
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r578161861
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -131,7 +131,8 @@ private void loadDumpFromFile() throws SemanticException {
lineContents[2].equals(Utilities.nullStringOutput) ? null : Long.valueOf(lineContents[2]),
lineContents[3].equals(Utilities.nullStringOutput) ? null : new Path(lineContents[3]),
lineContents[4].equals(Utilities.nullStringOutput) ? null : Long.valueOf(lineContents[4]),
- Boolean.valueOf(lineContents[6]));
+ (lineContents.length < 8 || lineContents[6].equals(Utilities.nullStringOutput)) ?
Review comment:
Add a test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org