You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Marta Kuczora via Review Board <no...@reviews.apache.org> on 2019/09/30 11:53:34 UTC

Review Request 71558: HIVE-21987: Hive is unable to read Parquet int32 annotated with decimal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71558/
-----------------------------------------------------------

Review request for hive and Peter Vary.


Bugs: HIVE-21987
    https://issues.apache.org/jira/browse/HIVE-21987


Repository: hive-git


Description
-------

Added support to read INT32 Parquet decimals.


Diffs
-----

  data/files/parquet_int_decimal_1.parquet PRE-CREATION 
  data/files/parquet_int_decimal_2.parquet PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java 350ae2d 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java 320ce52 
  ql/src/test/queries/clientpositive/parquet_int_decimal.q PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_int_decimal.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/type_change_test_fraction.q.out 07cf8fa 


Diff: https://reviews.apache.org/r/71558/diff/1/


Testing
-------

Added new q tests for the use-case.


Thanks,

Marta Kuczora


Re: Review Request 71558: HIVE-21987: Hive is unable to read Parquet int32 annotated with decimal

Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71558/#review217991
-----------------------------------------------------------


Ship it!




Ship It!

- Peter Vary


On szept. 30, 2019, 11:53 de, Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71558/
> -----------------------------------------------------------
> 
> (Updated szept. 30, 2019, 11:53 de)
> 
> 
> Review request for hive and Peter Vary.
> 
> 
> Bugs: HIVE-21987
>     https://issues.apache.org/jira/browse/HIVE-21987
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added support to read INT32 Parquet decimals.
> 
> 
> Diffs
> -----
> 
>   data/files/parquet_int_decimal_1.parquet PRE-CREATION 
>   data/files/parquet_int_decimal_2.parquet PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java 350ae2d 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java 320ce52 
>   ql/src/test/queries/clientpositive/parquet_int_decimal.q PRE-CREATION 
>   ql/src/test/results/clientpositive/parquet_int_decimal.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/type_change_test_fraction.q.out 07cf8fa 
> 
> 
> Diff: https://reviews.apache.org/r/71558/diff/1/
> 
> 
> Testing
> -------
> 
> Added new q tests for the use-case.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>