You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "chunweilei (via GitHub)" <gi...@apache.org> on 2023/09/18 08:40:59 UTC
[GitHub] [calcite] chunweilei commented on a diff in pull request #3404: [CALCITE-5968] Provide an interface for RexExecutable to decouple janino runtime binding
chunweilei commented on code in PR #3404:
URL: https://github.com/apache/calcite/pull/3404#discussion_r1328410380
##########
core/src/main/java/org/apache/calcite/rex/RexExecutable.java:
##########
@@ -17,100 +17,38 @@
package org.apache.calcite.rex;
import org.apache.calcite.DataContext;
-import org.apache.calcite.linq4j.function.Function1;
-import org.apache.calcite.runtime.Hook;
-import org.apache.calcite.runtime.Utilities;
-import org.apache.calcite.util.Pair;
import org.checkerframework.checker.nullness.qual.Nullable;
-import org.codehaus.commons.compiler.CompileException;
-import org.codehaus.janino.ClassBodyEvaluator;
-import org.codehaus.janino.Scanner;
-import java.io.IOException;
-import java.io.Serializable;
-import java.io.StringReader;
-import java.lang.reflect.Constructor;
-import java.lang.reflect.InvocationTargetException;
-import java.util.Arrays;
import java.util.List;
-import static java.util.Objects.requireNonNull;
-
/**
- * Result of compiling code generated from a {@link RexNode} expression.
+ * Executable interface for a {@link RexNode} expression.
*/
-public class RexExecutable {
- private static final String GENERATED_CLASS_NAME = "Reducer";
-
- private final Function1<DataContext, @Nullable Object @Nullable []> compiledFunction;
- private final String code;
- private @Nullable DataContext dataContext;
-
- public RexExecutable(String code, Object reason) {
- this.code = code;
- this.compiledFunction = compile(code, reason);
- }
-
- private static Function1<DataContext, @Nullable Object @Nullable []> compile(String code,
- Object reason) {
- try {
- final ClassBodyEvaluator cbe = new ClassBodyEvaluator();
- cbe.setClassName(GENERATED_CLASS_NAME);
- cbe.setExtendedClass(Utilities.class);
- cbe.setImplementedInterfaces(new Class[] {Function1.class, Serializable.class});
- cbe.setParentClassLoader(RexExecutable.class.getClassLoader());
- cbe.cook(new Scanner(null, new StringReader(code)));
- Class c = cbe.getClazz();
- //noinspection unchecked
- final Constructor<Function1<DataContext, @Nullable Object @Nullable []>> constructor =
- c.getConstructor();
- return constructor.newInstance();
- } catch (CompileException | IOException | InstantiationException
- | IllegalAccessException | InvocationTargetException
- | NoSuchMethodException e) {
- throw new RuntimeException("While compiling " + reason, e);
- }
- }
-
- public void setDataContext(DataContext dataContext) {
- this.dataContext = dataContext;
- }
-
- public void reduce(RexBuilder rexBuilder, List<RexNode> constExps,
- List<RexNode> reducedValues) {
- @Nullable Object[] values;
- try {
- values = execute();
- if (values == null) {
- reducedValues.addAll(constExps);
- values = new Object[constExps.size()];
- } else {
- assert values.length == constExps.size();
- final List<@Nullable Object> valueList = Arrays.asList(values);
- for (Pair<RexNode, @Nullable Object> value : Pair.zip(constExps, valueList)) {
- reducedValues.add(
- rexBuilder.makeLiteral(value.right, value.left.getType(), true));
- }
- }
- } catch (RuntimeException e) {
- // One or more of the expressions failed.
- // Don't reduce any of the expressions.
- reducedValues.addAll(constExps);
- values = new Object[constExps.size()];
- }
- Hook.EXPRESSION_REDUCER.run(Pair.of(code, values));
- }
-
- public Function1<DataContext, @Nullable Object @Nullable []> getFunction() {
- return compiledFunction;
- }
-
- public @Nullable Object @Nullable [] execute() {
- return compiledFunction.apply(requireNonNull(dataContext, "dataContext"));
- }
+public interface RexExecutable {
+
+ /** Reduces expressions, and writes their results into {@code reducedValues}.
+ *
+ * <p>If an expression cannot be reduced, writes the original expression.
+ * For example, {@code CAST('abc' AS INTEGER)} gives an error when executed, so the executor
+ * ignores the error and writes the original expression.
+ *
+ * @param rexBuilder Rex builder
Review Comment:
Some functions are deleted, which may cause compatibility issues in the downstream project. But I think it is accepted if the change is positive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org