You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/06/15 07:37:28 UTC

[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4965: [BEELINE] Remove comments for non python mode

bowenliang123 commented on code in PR #4965:
URL: https://github.com/apache/kyuubi/pull/4965#discussion_r1230572592


##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:
##########
@@ -155,7 +182,7 @@ int initArgs(String[] args) {
             DynMethods.builder("defaultBeelineConnect")
                 .hiddenImpl(BeeLine.class, CommandLine.class)
                 .buildChecked(this)
-                .invoke(beelineParser, cl);
+                .invoke(cl);

Review Comment:
   It seems my fault in #4879 . Apologize for adding the unrelated argument in the first place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org