You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2010/05/16 04:21:36 UTC
svn commit: r944756 -
/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java
Author: lu4242
Date: Sun May 16 02:21:36 2010
New Revision: 944756
URL: http://svn.apache.org/viewvc?rev=944756&view=rev
Log:
MYFACES-2718 h:commandButton does not take into account params when type="button"
Modified:
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java
Modified: myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java?rev=944756&r1=944755&r2=944756&view=diff
==============================================================================
--- myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java (original)
+++ myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java Sun May 16 02:21:36 2010
@@ -185,8 +185,14 @@ public class HtmlButtonRendererBase
}
else
{
- HtmlRendererUtils.renderBehaviorizedAttribute(facesContext, writer, uiComponent, behaviors,
- ClientBehaviorEvents.CLICK, HTML.ONCLICK_ATTR, HTML.ONCLICK_ATTR);
+ String onClick = HtmlRendererUtils.buildBehaviorChain(facesContext, uiComponent, behaviors,
+ ClientBehaviorEvents.CLICK, ClientBehaviorEvents.ACTION,
+ commandOnclick , null,
+ HtmlRendererUtils.mapAttachedParamsToStringValues(facesContext, uiComponent));
+ if (onClick.length() != 0)
+ {
+ writer.writeAttribute(HTML.ONCLICK_ATTR, onClick.toString(), null);
+ }
}
Map<String, Object> attributes = uiComponent.getAttributes();