You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 11:23:54 UTC

[GitHub] [arrow-rs] alamb commented on issue #43: [Parquet] Use IntoIter trait for write_batch/write_mini_batch

alamb commented on issue #43:
URL: https://github.com/apache/arrow-rs/issues/43#issuecomment-826757072


   Comment from Xavier Lange(xrl) @ 2019-04-09T19:22:29.534+0000:
   <pre>[~csun] [~sadikovi] what do you think of this potentially breaking change? I need to confirm the backwards compatibility but I think it might still be a useful change.</pre>
   
   Comment from Ivan Sadikov(sadikovi) @ 2019-04-09T19:33:52.271+0000:
   <pre>[~xrl] Yes, sure. I will be happy to review if you open a PR with changes. We can create a new method "write_batch_iter", which implements new API and make "write_batch" to call the new method, since as you pointed out slice implements IntoIter.</pre>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org