[GitHub] [skywalking-rover] mrproliu commented on a diff in pull request #39: Support Network Profiling

[GitBox <gi...@apache.org>]

mrproliu commented on code in PR #39:
URL: https://github.com/apache/skywalking-rover/pull/39#discussion_r919053809


##########
configs/rover_configs.yaml:
##########
@@ -112,5 +112,10 @@ profiling:
   task:
     # The config when executing ON_CPU profiling task
     on_cpu:
-      # the profiling stack dump period
-      dump_period: ${ROVER_PROFILING_TASK_ON_CPU_DUMP_PERIOD:9ms}
\ No newline at end of file
+      # The profiling stack dump period
+      dump_period: ${ROVER_PROFILING_TASK_ON_CPU_DUMP_PERIOD:9ms}
+    network:
+      # The interval of send metrics to the backend
+      report_interval: ${ROVER_PROFILING_TASK_NETWORK_TOPOLOGY_REPORT_INTERVAL:2s}
+      # The prefix of network profiling metrics name
+      meter_prefix: ${ROVER_PROFILING_TASK_NETWORK_TOPOLOGY_METER_PREFIX:rover_network_profiling}

Review Comment:
   The name could be shorter. How about rename to "rover_network" or do you have any suggestions? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org