You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Sutou Kouhei <ko...@clear-code.com> on 2020/02/03 00:55:23 UTC
[Gandiva] LLVM version
Hi,
Does Gandiva have any policy about LLVM version?
The current Gandiva requires LLVM 7. Other LLVM versions
aren't supported. But the latest LLVM is 9. Can we upgrade
LLVM?
Homebrew provides LLVM 4, 6, 7, 8 and 9 but doesn't accept
apache-arrow package that depends outdated LLVM:
https://github.com/Homebrew/homebrew-core/pull/42385
It means that apache-arrow package on Homebrew can't enable
Gandiva until we upgrade LLVM to the latest version.
We have a pull request that upgrades supported LLVM to 8:
https://github.com/apache/arrow/pull/6266
In the pull request, Wes mentioned to Gandiva developers but
there are no responses.
In the pull request, there are no Gandiva changes. So we
will be able to support LLVM 7 and 8 without any #ifdef.
Can we support multiple LLVM versions? Or should we support
only one LLVM version?
I think that we can consider C++ tools provided by LLVM such
as clang-format separately. We will be able to use different
LLVM versions for Gandiva and C++ tools. For example, we
will be able to use LLVM 8 for Gandiva and LLVM 7 for
clang-format at the same time by improving our CMake
configuration.
Thanks,
--
kou
Re: [Gandiva] LLVM version
Posted by Sutou Kouhei <ko...@clear-code.com>.
Thanks!
In <3a...@www.fastmail.com>
"Re: [Gandiva] LLVM version" on Tue, 04 Feb 2020 17:36:12 +0530,
"Projjal Chanda" <ia...@pchanda.com> wrote:
> Hi Kou,
> Sure. I will let you know.
>
> Regards,
> Projjal
>
> On Tue, Feb 4, 2020, at 2:20 AM, Sutou Kouhei wrote:
>> Hi Projjal,
>>
>> > Let me test the change by running it with Dremio.
>>
>> Thanks!
>>
>> > Will update if there are any issues.
>>
>> It means that we can move forward if we don't get any
>> responses from you in a week (long? short?), right?
>>
>>
>> Thanks,
>> --
>> kou
>>
>> In <29...@www.fastmail.com>
>> "Re: [Gandiva] LLVM version" on Mon, 03 Feb 2020 11:26:43 +0530,
>> "Projjal Chanda" <ia...@pchanda.com> wrote:
>>
>> > Hi Kou,
>> > Let me test the change by running it with Dremio. Will update if there are any issues.
>> >
>> > Regards,
>> > Projjal
>> >
>> > On Mon, Feb 3, 2020, at 9:11 AM, Wes McKinney wrote:
>> >> hi Kou,
>> >>
>> >> Since nearly 2 weeks have passed, and the changes do not seem too
>> >> risky, absent more comments I think it's safe to move forward with the
>> >> upgrade.
>> >>
>> >> - Wes
>> >>
>> >> On Sun, Feb 2, 2020 at 6:55 PM Sutou Kouhei <ko...@clear-code.com> wrote:
>> >> >
>> >> > Hi,
>> >> >
>> >> > Does Gandiva have any policy about LLVM version?
>> >> >
>> >> > The current Gandiva requires LLVM 7. Other LLVM versions
>> >> > aren't supported. But the latest LLVM is 9. Can we upgrade
>> >> > LLVM?
>> >> >
>> >> > Homebrew provides LLVM 4, 6, 7, 8 and 9 but doesn't accept
>> >> > apache-arrow package that depends outdated LLVM:
>> >> >
>> >> > https://github.com/Homebrew/homebrew-core/pull/42385
>> >> >
>> >> > It means that apache-arrow package on Homebrew can't enable
>> >> > Gandiva until we upgrade LLVM to the latest version.
>> >> >
>> >> >
>> >> > We have a pull request that upgrades supported LLVM to 8:
>> >> > https://github.com/apache/arrow/pull/6266
>> >> >
>> >> > In the pull request, Wes mentioned to Gandiva developers but
>> >> > there are no responses.
>> >> >
>> >> >
>> >> > In the pull request, there are no Gandiva changes. So we
>> >> > will be able to support LLVM 7 and 8 without any #ifdef.
>> >> > Can we support multiple LLVM versions? Or should we support
>> >> > only one LLVM version?
>> >> >
>> >> >
>> >> > I think that we can consider C++ tools provided by LLVM such
>> >> > as clang-format separately. We will be able to use different
>> >> > LLVM versions for Gandiva and C++ tools. For example, we
>> >> > will be able to use LLVM 8 for Gandiva and LLVM 7 for
>> >> > clang-format at the same time by improving our CMake
>> >> > configuration.
>> >> >
>> >> >
>> >> > Thanks,
>> >> > --
>> >> > kou
>> >>
>>
Re: [Gandiva] LLVM version
Posted by Projjal Chanda <ia...@pchanda.com>.
Hi Kou,
Sure. I will let you know.
Regards,
Projjal
On Tue, Feb 4, 2020, at 2:20 AM, Sutou Kouhei wrote:
> Hi Projjal,
>
> > Let me test the change by running it with Dremio.
>
> Thanks!
>
> > Will update if there are any issues.
>
> It means that we can move forward if we don't get any
> responses from you in a week (long? short?), right?
>
>
> Thanks,
> --
> kou
>
> In <29...@www.fastmail.com>
> "Re: [Gandiva] LLVM version" on Mon, 03 Feb 2020 11:26:43 +0530,
> "Projjal Chanda" <ia...@pchanda.com> wrote:
>
> > Hi Kou,
> > Let me test the change by running it with Dremio. Will update if there are any issues.
> >
> > Regards,
> > Projjal
> >
> > On Mon, Feb 3, 2020, at 9:11 AM, Wes McKinney wrote:
> >> hi Kou,
> >>
> >> Since nearly 2 weeks have passed, and the changes do not seem too
> >> risky, absent more comments I think it's safe to move forward with the
> >> upgrade.
> >>
> >> - Wes
> >>
> >> On Sun, Feb 2, 2020 at 6:55 PM Sutou Kouhei <ko...@clear-code.com> wrote:
> >> >
> >> > Hi,
> >> >
> >> > Does Gandiva have any policy about LLVM version?
> >> >
> >> > The current Gandiva requires LLVM 7. Other LLVM versions
> >> > aren't supported. But the latest LLVM is 9. Can we upgrade
> >> > LLVM?
> >> >
> >> > Homebrew provides LLVM 4, 6, 7, 8 and 9 but doesn't accept
> >> > apache-arrow package that depends outdated LLVM:
> >> >
> >> > https://github.com/Homebrew/homebrew-core/pull/42385
> >> >
> >> > It means that apache-arrow package on Homebrew can't enable
> >> > Gandiva until we upgrade LLVM to the latest version.
> >> >
> >> >
> >> > We have a pull request that upgrades supported LLVM to 8:
> >> > https://github.com/apache/arrow/pull/6266
> >> >
> >> > In the pull request, Wes mentioned to Gandiva developers but
> >> > there are no responses.
> >> >
> >> >
> >> > In the pull request, there are no Gandiva changes. So we
> >> > will be able to support LLVM 7 and 8 without any #ifdef.
> >> > Can we support multiple LLVM versions? Or should we support
> >> > only one LLVM version?
> >> >
> >> >
> >> > I think that we can consider C++ tools provided by LLVM such
> >> > as clang-format separately. We will be able to use different
> >> > LLVM versions for Gandiva and C++ tools. For example, we
> >> > will be able to use LLVM 8 for Gandiva and LLVM 7 for
> >> > clang-format at the same time by improving our CMake
> >> > configuration.
> >> >
> >> >
> >> > Thanks,
> >> > --
> >> > kou
> >>
>
Re: [Gandiva] LLVM version
Posted by Sutou Kouhei <ko...@clear-code.com>.
Hi Projjal,
> Let me test the change by running it with Dremio.
Thanks!
> Will update if there are any issues.
It means that we can move forward if we don't get any
responses from you in a week (long? short?), right?
Thanks,
--
kou
In <29...@www.fastmail.com>
"Re: [Gandiva] LLVM version" on Mon, 03 Feb 2020 11:26:43 +0530,
"Projjal Chanda" <ia...@pchanda.com> wrote:
> Hi Kou,
> Let me test the change by running it with Dremio. Will update if there are any issues.
>
> Regards,
> Projjal
>
> On Mon, Feb 3, 2020, at 9:11 AM, Wes McKinney wrote:
>> hi Kou,
>>
>> Since nearly 2 weeks have passed, and the changes do not seem too
>> risky, absent more comments I think it's safe to move forward with the
>> upgrade.
>>
>> - Wes
>>
>> On Sun, Feb 2, 2020 at 6:55 PM Sutou Kouhei <ko...@clear-code.com> wrote:
>> >
>> > Hi,
>> >
>> > Does Gandiva have any policy about LLVM version?
>> >
>> > The current Gandiva requires LLVM 7. Other LLVM versions
>> > aren't supported. But the latest LLVM is 9. Can we upgrade
>> > LLVM?
>> >
>> > Homebrew provides LLVM 4, 6, 7, 8 and 9 but doesn't accept
>> > apache-arrow package that depends outdated LLVM:
>> >
>> > https://github.com/Homebrew/homebrew-core/pull/42385
>> >
>> > It means that apache-arrow package on Homebrew can't enable
>> > Gandiva until we upgrade LLVM to the latest version.
>> >
>> >
>> > We have a pull request that upgrades supported LLVM to 8:
>> > https://github.com/apache/arrow/pull/6266
>> >
>> > In the pull request, Wes mentioned to Gandiva developers but
>> > there are no responses.
>> >
>> >
>> > In the pull request, there are no Gandiva changes. So we
>> > will be able to support LLVM 7 and 8 without any #ifdef.
>> > Can we support multiple LLVM versions? Or should we support
>> > only one LLVM version?
>> >
>> >
>> > I think that we can consider C++ tools provided by LLVM such
>> > as clang-format separately. We will be able to use different
>> > LLVM versions for Gandiva and C++ tools. For example, we
>> > will be able to use LLVM 8 for Gandiva and LLVM 7 for
>> > clang-format at the same time by improving our CMake
>> > configuration.
>> >
>> >
>> > Thanks,
>> > --
>> > kou
>>
Re: [Gandiva] LLVM version
Posted by Projjal Chanda <ia...@pchanda.com>.
Hi Kou,
Let me test the change by running it with Dremio. Will update if there are any issues.
Regards,
Projjal
On Mon, Feb 3, 2020, at 9:11 AM, Wes McKinney wrote:
> hi Kou,
>
> Since nearly 2 weeks have passed, and the changes do not seem too
> risky, absent more comments I think it's safe to move forward with the
> upgrade.
>
> - Wes
>
> On Sun, Feb 2, 2020 at 6:55 PM Sutou Kouhei <ko...@clear-code.com> wrote:
> >
> > Hi,
> >
> > Does Gandiva have any policy about LLVM version?
> >
> > The current Gandiva requires LLVM 7. Other LLVM versions
> > aren't supported. But the latest LLVM is 9. Can we upgrade
> > LLVM?
> >
> > Homebrew provides LLVM 4, 6, 7, 8 and 9 but doesn't accept
> > apache-arrow package that depends outdated LLVM:
> >
> > https://github.com/Homebrew/homebrew-core/pull/42385
> >
> > It means that apache-arrow package on Homebrew can't enable
> > Gandiva until we upgrade LLVM to the latest version.
> >
> >
> > We have a pull request that upgrades supported LLVM to 8:
> > https://github.com/apache/arrow/pull/6266
> >
> > In the pull request, Wes mentioned to Gandiva developers but
> > there are no responses.
> >
> >
> > In the pull request, there are no Gandiva changes. So we
> > will be able to support LLVM 7 and 8 without any #ifdef.
> > Can we support multiple LLVM versions? Or should we support
> > only one LLVM version?
> >
> >
> > I think that we can consider C++ tools provided by LLVM such
> > as clang-format separately. We will be able to use different
> > LLVM versions for Gandiva and C++ tools. For example, we
> > will be able to use LLVM 8 for Gandiva and LLVM 7 for
> > clang-format at the same time by improving our CMake
> > configuration.
> >
> >
> > Thanks,
> > --
> > kou
>
Re: [Gandiva] LLVM version
Posted by Wes McKinney <we...@gmail.com>.
hi Kou,
Since nearly 2 weeks have passed, and the changes do not seem too
risky, absent more comments I think it's safe to move forward with the
upgrade.
- Wes
On Sun, Feb 2, 2020 at 6:55 PM Sutou Kouhei <ko...@clear-code.com> wrote:
>
> Hi,
>
> Does Gandiva have any policy about LLVM version?
>
> The current Gandiva requires LLVM 7. Other LLVM versions
> aren't supported. But the latest LLVM is 9. Can we upgrade
> LLVM?
>
> Homebrew provides LLVM 4, 6, 7, 8 and 9 but doesn't accept
> apache-arrow package that depends outdated LLVM:
>
> https://github.com/Homebrew/homebrew-core/pull/42385
>
> It means that apache-arrow package on Homebrew can't enable
> Gandiva until we upgrade LLVM to the latest version.
>
>
> We have a pull request that upgrades supported LLVM to 8:
> https://github.com/apache/arrow/pull/6266
>
> In the pull request, Wes mentioned to Gandiva developers but
> there are no responses.
>
>
> In the pull request, there are no Gandiva changes. So we
> will be able to support LLVM 7 and 8 without any #ifdef.
> Can we support multiple LLVM versions? Or should we support
> only one LLVM version?
>
>
> I think that we can consider C++ tools provided by LLVM such
> as clang-format separately. We will be able to use different
> LLVM versions for Gandiva and C++ tools. For example, we
> will be able to use LLVM 8 for Gandiva and LLVM 7 for
> clang-format at the same time by improving our CMake
> configuration.
>
>
> Thanks,
> --
> kou