You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by ma...@apache.org on 2022/11/20 22:27:38 UTC
[nifi] branch main updated: NIFI-10812: Remove duplicate record template creation from Iceberg record converter
This is an automated email from the ASF dual-hosted git repository.
mattyb149 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git
The following commit(s) were added to refs/heads/main by this push:
new 594e93d97e NIFI-10812: Remove duplicate record template creation from Iceberg record converter
594e93d97e is described below
commit 594e93d97ee951f902ba513bb3656ce937010ebf
Author: Mark Bathori <ba...@gmail.com>
AuthorDate: Mon Nov 14 10:33:53 2022 +0100
NIFI-10812: Remove duplicate record template creation from Iceberg record converter
Signed-off-by: Matthew Burgess <ma...@apache.org>
This closes #6659
---
.../nifi/processors/iceberg/converter/GenericDataConverters.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/converter/GenericDataConverters.java b/nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/converter/GenericDataConverters.java
index d216299d18..7235b16cab 100644
--- a/nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/converter/GenericDataConverters.java
+++ b/nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/converter/GenericDataConverters.java
@@ -211,15 +211,13 @@ public class GenericDataConverters {
@Override
public GenericRecord convert(Record data) {
- final GenericRecord template = GenericRecord.create(schema);
- // GenericRecord.copy() is more performant then GenericRecord.create(StructType) since NAME_MAP_CACHE access is eliminated. Using copy here to gain performance.
- final GenericRecord result = template.copy();
+ final GenericRecord record = GenericRecord.create(schema);
for (int i = 0; i < converters.length; i += 1) {
- result.set(i, convert(data, i, converters[i]));
+ record.set(i, convert(data, i, converters[i]));
}
- return result;
+ return record;
}
@SuppressWarnings("unchecked")