You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "KatalKavya96 (via GitHub)" <gi...@apache.org> on 2026/09/10 11:38:47 UTC
[PR] feat(bitbucket): add guarded cloud PR decline [magpie]
KatalKavya96 opened a new pull request, #1194:
URL: https://github.com/apache/magpie/pull/1194
## Summary
Adds a guarded Bitbucket Cloud pull-request decline mutation to the existing Bitbucket bridge.
This PR adds:
* `magpie-bitbucket pr decline <id>`
The command operates on Bitbucket Cloud only. Bitbucket Data Center decline writes remain explicitly unsupported in this PR.
## Implementation
* Adds Bitbucket Cloud pull-request decline using `POST`.
* Reuses the existing guarded HTTPS-only write path.
* Keeps authenticated mutation redirects rejected.
* Adds explicit Data Center fail-closed behavior.
* Adds normalized decline output.
* Adds CLI dispatch for `pr decline <id>`.
* Updates Bitbucket bridge documentation and adapter coverage.
## Safety / write-path discipline
Decline remains an explicit caller-confirmed mutation.
The bridge does not decline pull requests automatically. The calling skill is responsible for obtaining explicit user confirmation before invoking the command.
## Tests
Added coverage for:
* Cloud decline using `POST` with no request body
* decline response handling
* normalized decline output
* CLI `pr decline` dispatch
* Data Center fail-closed behavior
Validation completed successfully:
* focused decline tests
* full Bitbucket test suite
* Ruff
* Ruff format check
* mypy
* repository prek hooks
* `git diff --check`
## Scope
This intentionally remains a narrow follow-up to #606.
It does not add:
* full `post_review`
* PR merge
* Data Center decline writes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add guarded cloud PR decline [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1194:
URL: https://github.com/apache/magpie/pull/1194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add guarded cloud PR decline [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1194:
URL: https://github.com/apache/magpie/pull/1194#issuecomment-5627579956
Pushed a one-line fixup rather than round-tripping: dropped `declining,` from the out-of-scope write list in `tools/bitbucket/README.md`, exactly as @AmirF194 identified — the paragraph claimed decline as implemented and out of scope at the same time, and the command table already listed `pr decline <id>`. Everything else was a clean match for the #1192 pattern, so this is merged. Thanks both — nice catch on the contradiction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add guarded cloud PR decline [magpie]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #1194:
URL: https://github.com/apache/magpie/pull/1194#issuecomment-5618062337
Hi @potiuk — another narrow #606 follow-up, continuing the Cloud PR mutation sequence.
This adds guarded `pr decline <id>`, reuses the existing HTTPS + no-auth-redirect write path, and keeps Data Center decline explicitly fail-closed.
Focused decline tests, the full Bitbucket suite, Ruff, mypy, prek hooks, and `git diff --check` are green.
Would appreciate your review when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add guarded cloud PR decline [magpie]
Posted by "AmirF194 (via GitHub)" <gi...@apache.org>.
AmirF194 commented on code in PR #1194:
URL: https://github.com/apache/magpie/pull/1194#discussion_r3984059801
##########
tools/bitbucket/README.md:
##########
@@ -95,7 +96,7 @@ activity where exposed by the configured Bitbucket backend.
Write coverage is intentionally narrow. The bridge supports confirmed
Bitbucket Cloud issue-comment creation, top-level pull-request comment creation,
-and pull-request approve/unapprove and request-changes/remove-request-changes actions after the calling skill has obtained
+and pull-request approve/unapprove, request-changes/remove-request-changes, and decline actions after the calling skill has obtained
explicit user confirmation. Other writes, such as editing/deleting comments,
declining, merging, creating/updating issues, changing branches, or triggering
Review Comment:
This PR adds `pr decline` as a supported write action but leaves a contradicting sentence two lines below it.
`README.md:99` now lists decline alongside the other implemented writes ("and pull-request approve/unapprove, request-changes/remove-request-changes, and decline actions"), but `README.md:101` still lists "declining" in the same paragraph's "Other writes ... remain out of scope" sentence. Both sentences describe the same write-coverage boundary and now disagree with each other, and with the new `pr decline <id>` row in the command table at line 158.
Fix is one edit: drop "declining," from the out-of-scope list at line 101.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add guarded cloud PR decline [magpie]
Posted by "AmirF194 (via GitHub)" <gi...@apache.org>.
AmirF194 commented on code in PR #1194:
URL: https://github.com/apache/magpie/pull/1194#discussion_r3984816443
##########
tools/bitbucket/README.md:
##########
@@ -95,7 +96,7 @@ activity where exposed by the configured Bitbucket backend.
Write coverage is intentionally narrow. The bridge supports confirmed
Bitbucket Cloud issue-comment creation, top-level pull-request comment creation,
-and pull-request approve/unapprove and request-changes/remove-request-changes actions after the calling skill has obtained
+and pull-request approve/unapprove, request-changes/remove-request-changes, and decline actions after the calling skill has obtained
explicit user confirmation. Other writes, such as editing/deleting comments,
declining, merging, creating/updating issues, changing branches, or triggering
Review Comment:
Confirmed, commit 3d7b3f5 removes "declining" from the out-of-scope-writes sentence, matching the new decline support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org