You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mxm (via GitHub)" <gi...@apache.org> on 2023/05/05 12:00:09 UTC
[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #584: [FLINK-31867] Enforce a minimum number of observations within a metric window
mxm commented on code in PR #584:
URL: https://github.com/apache/flink-kubernetes-operator/pull/584#discussion_r1186008994
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java:
##########
@@ -52,6 +52,13 @@ private static ConfigOptions.OptionBuilder autoScalerConfig(String key) {
.defaultValue(Duration.ofMinutes(5))
.withDescription("Scaling metrics aggregation window size.");
+ public static final ConfigOption<Integer> METRICS_WINDOW_MIN_OBSERVATIONS =
+ autoScalerConfig("metrics.window.min-observations")
+ .intType()
+ .defaultValue(10)
Review Comment:
True, the metric collection interval is coupled with the reconciliation interval (60 seconds by default). If we chose to calculate the min observations dynamically, I wonder whether we should even expose this as a config option then. It is more of a sanity check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org