You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2019/10/17 22:48:19 UTC

[kudu-CR] [ksck] KUDU-2964 Remove per server warn message when GetFlags call fails

Hello Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14460

to look at the new patch set (#3).

Change subject: [ksck] KUDU-2964 Remove per server warn message when GetFlags call fails
......................................................................

[ksck] KUDU-2964 Remove per server warn message when GetFlags call fails

Logging individual master/tablet server warning message on
failure to fetch flags is unnecessarily verbose since
the cause is almost always the same, either the server is unavailable
or GetFlags RPC is not available because server is old.

There is already a summary of number of masters/tablet servers
that failed to respond to GetFlags request. So remove the per server
warning message.

Tests:
- Invoked ksck against KUDU version 1.4.0.

Warnings:
==================
master flag check error: 1 of 1 masters' flags were not available
tserver flag check error: 2 of 2 tservers' flags were not available

Change-Id: I06dd417b9bf5274f90bbdb9338600ea518e82809
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 36 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/14460/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06dd417b9bf5274f90bbdb9338600ea518e82809
Gerrit-Change-Number: 14460
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)