You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 07:18:24 UTC

[GitHub] [camel-website] psingh587 opened a new pull request #190: Improved the frontpage header text size

psingh587 opened a new pull request #190: Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190
 
 
   Regarding the issue raised by me 
   https://issues.apache.org/jira/browse/CAMEL-14693

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #190: Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #190: Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597481881
 
 
   ![WhatsApp Image 2020-03-11 at 12 51 41](https://user-images.githubusercontent.com/51945896/76392263-36debd00-6397-11ea-83a5-d06c187414fc.jpeg)
   
   After this changes it looks something like this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597512017
 
 
   > I think we have this issue fixed in #185 already.
   
   Yes sir. Just checked it :)
   I will close this PR then

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597502528
 
 
   @psingh587 we build in containers and sometimes we have issues with stopping them (unsure of the reason why), I've restarted the build, it's usually on the second go that the issue doesn't manifest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 edited a comment on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597509569
 
 
   > I think we have this issue fixed in #185 already.
   @zregvart 
   Sir , i had checked that PR. But i guess its a little different from what i have tried to do here.
   I have decreased the font-size when screen width turned to 1023 px which i think stays in PR #185. I thought it would be good if the font is not that big that it is now when screen width is 1023px.
      

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597509569
 
 
   > I think we have this issue fixed in #185 already.
   
   Sir , i had checked that PR. But i guess its a little different from what i have tried to do here.
   I have decreased the font-size when screen width turned to 1023 px which i think stays in PR #185. I thought it would be good if the font is not that big that it is now when screen width is 1023px.
      

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597536412
 
 
   The preview is [here](https://builds.apache.org/job/Camel.website/job/PR-190/Preview/index.html). @psingh587 if you'd like to rebase on the current `master` branch and see if there are more improvements you can add on top of #185 you're more than welcome.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 closed pull request #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 closed pull request #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597507642
 
 
   I think we have this issue fixed in #185 already.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #190: Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #190: Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597497675
 
 
   @zregvart  
   Sorry sir, looks like some checks have failed.
   Please guide me where i was wrong.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 removed a comment on issue #190: CAMEL-14693 : Improved the frontpage header text size

Posted by GitBox <gi...@apache.org>.
psingh587 removed a comment on issue #190: CAMEL-14693 : Improved the frontpage header text size
URL: https://github.com/apache/camel-website/pull/190#issuecomment-597509569
 
 
   > I think we have this issue fixed in #185 already.
   @zregvart 
   Sir , i had checked that PR. But i guess its a little different from what i have tried to do here.
   I have decreased the font-size when screen width turned to 1023 px which i think stays in PR #185. I thought it would be good if the font is not that big that it is now when screen width is 1023px.
      

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services