You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/12/01 15:15:00 UTC
[jira] [Commented] (SOLR-17994) Rename HttpClientBuilderFactory to SolrClientCustomizer
[ https://issues.apache.org/jira/browse/SOLR-17994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041871#comment-18041871 ]
ASF subversion and git services commented on SOLR-17994:
--------------------------------------------------------
Commit d7941818b495a817b897bf34d4151006e167db06 in solr's branch refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=d7941818b49 ]
SOLR-17994: SolrClientCustomizer (#3876)
* Rename HttpClientBuilderFactory to SolrClientCustomizer, generalizing it.
* Rename property solr.httpclient.builder.factory to solr.solrj.http.jetty.customizer
* Rename PreemptiveBasicAuthClientBuilderFactory to PreemptiveBasicAuthClientCustomizer
> Rename HttpClientBuilderFactory to SolrClientCustomizer
> -------------------------------------------------------
>
> Key: SOLR-17994
> URL: https://issues.apache.org/jira/browse/SOLR-17994
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> HttpClientBuilderFactory's name doesn't make sense anymore, if it ever did. It has evolved. It's not a factory for a builder of HttpClients, as its name might suggest. It's a customizer for a SolrClient that was recently constructed. At present it's only used for Http2SolrClient (Jetty) but it's quite plausible to imagine using it for the JDK one, if we so choose. We might evolve it to configure a builder, which would be nice because it would make it easier to make clients immutable (no back-doors). Still, calling this a SolrClient customizer still sounds like a good name. But it's not a factory, and it's not a builder! It's definitely a customizer/configurer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org