You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/05 00:13:15 UTC

[GitHub] [kafka] hachikuji commented on pull request #9802: KAFKA-10894; Ensure PartitionInfo replicas are not null in client quota callback

hachikuji commented on pull request #9802:
URL: https://github.com/apache/kafka/pull/9802#issuecomment-754302596


   @chia7712 Good question about `leader()`. I looked into usage and it seems we do not have consistent `isEmpty` checks, so I'm a little concerned about compatibility if we change that. To be honest, I do not like the use of the empty sentinel. It seems like a dangerous practice and I'm not too eager to expand its usage. However, given the choice between returning a list of replica nodes which contains null values (what is done today for this callback) and making use of the empty sentinel in the same way  that it is already used in the client logic, the latter seems preferable. Does that make sense?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org