You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/05/29 21:16:29 UTC

[GitHub] [commons-imaging] kinow commented on a change in pull request #43: Feature/deflate

kinow commented on a change in pull request #43: Feature/deflate
URL: https://github.com/apache/commons-imaging/pull/43#discussion_r288772326
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/tiff/TiffReader.java
 ##########
 @@ -412,7 +423,7 @@ public void read(final ByteSource byteSource, final Map<String, Object> params,
         readDirectories(byteSource, formatCompliance, listener);
     }
 
-    private TiffImageData getTiffRawImageData(final ByteSource byteSource,
+    public TiffImageData getTiffRawImageData(final ByteSource byteSource,
 
 Review comment:
   Making methods that were private now public always need a short explanation, as these methods will be now part of the maintained API accessible by users, and we will have to have more care to change it.
   
   Could you explain why these two methods in TiffReader are public and not private, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services