You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/19 12:25:31 UTC

[GitHub] [dubbo-go] sheny1xuan opened a new pull request, #1845: fix: limit rpc package data size by user's config rather than DEFAULT_LEN.

sheny1xuan opened a new pull request, #1845:
URL: https://github.com/apache/dubbo-go/pull/1845

   
   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**: 
   
     * Dubbo recommand package data length not greater than 8MiB.
     * If package data length greater than 8MiB, generate warnning.
     * If package data lenght greater than user's config, generate exception.
   
   Signed-off-by: stonex <14...@qq.com>
   
   **Which issue(s) this PR fixes**: 
   Fixes #1839
   
   **You should pay attention to items below to ensure your pr passes our ci test**
   We do not merge pr with ci tests failed
   
   - [x] All ut passed (run 'go test ./...' in project root)
   - [x] After go-fmt ed , run 'go fmt project' using goland.
   - [x] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
   - [x] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above) 
   - [x] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
   - [x] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1845: fix: limit rpc package data size by user's config rather than DEFAULT_LEN.

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on PR #1845:
URL: https://github.com/apache/dubbo-go/pull/1845#issuecomment-1103389307

   @sheny1xuan 提交代码到3.0分支。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sheny1xuan closed pull request #1845: fix: limit rpc package data size by user's config rather than DEFAULT_LEN.

Posted by GitBox <gi...@apache.org>.
sheny1xuan closed pull request #1845: fix: limit rpc package data size by user's config rather than DEFAULT_LEN.
URL: https://github.com/apache/dubbo-go/pull/1845


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sheny1xuan commented on pull request #1845: fix: limit rpc package data size by user's config rather than DEFAULT_LEN.

Posted by GitBox <gi...@apache.org>.
sheny1xuan commented on PR #1845:
URL: https://github.com/apache/dubbo-go/pull/1845#issuecomment-1103494212

   > @sheny1xuan 提交代码到3.0分支。
   
   好的，那这个pr我关掉了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org