You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/20 08:26:12 UTC
[GitHub] [apisix] LY-GO opened a new pull request #2475: Bug limit conn
LY-GO opened a new pull request #2475:
URL: https://github.com/apache/apisix/pull/2475
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO edited a comment on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
LY-GO edited a comment on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-713651479
> Feel free to modify code of plugin, it just a PR :) LY-GO <no...@github.com>于2020年10月21日 周三下午11:02写道：
> @LY-GO <https://github.com/LY-GO> why you create a new plugin? i don"t create a new plugin,i just add some annotation;And i don't want to destory your code,so i create a new plugin ,but code of new plugin is same as first. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <[#2475 (comment)](https://github.com/apache/apisix/pull/2475#issuecomment-713641911)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZBK22NR5WP45HO6Y4GSTSL3ZYRANCNFSM4SX2WBJQ> .
> -- Thanks, Ming Wen Twitter: _WenMing
i want to realize the difference between limit-req and limit-conn ;now i realize that limit-req can limit request and limit-con can limit connection.Is that so?
<img width="953" alt="req and conn" src="https://user-images.githubusercontent.com/67543312/96740516-7f615d00-13f3-11eb-9677-065b58d95b5e.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-713264980
@LY-GO why you create a new plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
LY-GO commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-713641911
> @LY-GO why you create a new plugin?
i don"t create a new plugin,i just add some annotation;And i don't want to destory your code,so i create a new plugin ,but code of new plugin is same as first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-713645012
Feel free to modify code of plugin, it just a PR :)
LY-GO <no...@github.com>于2020年10月21日 周三下午11:02写道：
> @LY-GO <https://github.com/LY-GO> why you create a new plugin?
>
> i don"t create a new plugin,i just add some annotation;And i don't want to
> destory your code,so i create a new plugin ,but code of new plugin is same
> as first.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/apisix/pull/2475#issuecomment-713641911>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK22NR5WP45HO6Y4GSTSL3ZYRANCNFSM4SX2WBJQ>
> .
>
--
Thanks,
Ming Wen
Twitter: _WenMing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-712709404
you need to fix the error message which prints by CI:
https://github.com/apache/apisix/pull/2475/checks?check_run_id=1279803708#step:9:124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2475: DO NOT MERGE ME, FOR TESTING! !
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-715019562
@LY-GO what is the configuration value you used for plugin `zxl-limit-conn` ? please confirm you can get an error with it.
then we'll help you to confirm what is your problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-713977282
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2475: DO NOT MERGE ME, FOR TESTING! !
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-715095758
> Thanks,this probleam i had sloved.
got it. close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on pull request #2475: Bug limit conn
Posted by GitBox <gi...@apache.org>.
LY-GO commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-713651479
> Feel free to modify code of plugin, it just a PR :) LY-GO <no...@github.com>于2020年10月21日 周三下午11:02写道：
> @LY-GO <https://github.com/LY-GO> why you create a new plugin? i don"t create a new plugin,i just add some annotation;And i don't want to destory your code,so i create a new plugin ,but code of new plugin is same as first. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <[#2475 (comment)](https://github.com/apache/apisix/pull/2475#issuecomment-713641911)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZBK22NR5WP45HO6Y4GSTSL3ZYRANCNFSM4SX2WBJQ> .
> -- Thanks, Ming Wen Twitter: _WenMing
i want to realize the difference between limit-req and limit-conn ;now i realize that limit-req can limit request and limit-con can limit connection.Is that so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis closed pull request #2475: DO NOT MERGE ME, FOR TESTING! !
Posted by GitBox <gi...@apache.org>.
membphis closed pull request #2475:
URL: https://github.com/apache/apisix/pull/2475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on pull request #2475: DO NOT MERGE ME, FOR TESTING! !
Posted by GitBox <gi...@apache.org>.
LY-GO commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-715061898
> then we'll help you to confirm what is your problem.
Thanks,this probleam i had sloved.I The error only is caused by my plan of test;i ignore the sleep time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org