You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by wlsc <gi...@git.apache.org> on 2017/05/14 09:04:43 UTC

[GitHub] kafka pull request #3049: MINOR: removed code duplicates from several files ...

GitHub user wlsc opened a pull request:

    https://github.com/apache/kafka/pull/3049

    MINOR: removed code duplicates from several files (KafkaStreams)

    This PR offers following to KafkaStreams project:
    * removed code duplication from **TopologyBuilder**'s function **makeNodeGroups** (extract function)
    * removed code duplication from **GlobalProcessorContextImpl** and from **ProcessorContextImpl** to parent class **AbstractProcessorContext** (move method to parent)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wlsc/kafka refactoring/remove-duplicates

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3049
    
----
commit fa90d68f7d547f54ae48a8254acac4759ddd4580
Author: Wladimir Schmidt <wl...@gmail.com>
Date:   2017-05-14T08:33:28Z

    removed code duplicate from GlobalProcessorContextImpl and
    from ProcessorContextImpl to parent AbstractProcessorContext

commit 6c70019a2d8f6b98b29366576f3b9f531ec0aea4
Author: Wladimir Schmidt <wl...@gmail.com>
Date:   2017-05-14T08:48:37Z

    removed code duplicate from TopologyBuilder's function "makeNodeGroups"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---