You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by voyageth <gi...@git.apache.org> on 2016/06/27 10:28:49 UTC
[GitHub] zeppelin pull request #1093: [Bug Fix] Fix "stackedAreaChart", "lineWithFocu...
GitHub user voyageth opened a pull request:
https://github.com/apache/zeppelin/pull/1093
[Bug Fix] Fix "stackedAreaChart", "lineWithFocusChart" graph when dataset contains "NULL" value.
### What is this PR for?
Fix "stackedAreaChart", "lineWithFocusChart" graph when dataset contains "NULL" value.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Check side effect.
* [ ] - Need fix when maxRowValue == rowIdx
### How should this be tested?
Test when row data set is like this on 1777 line.
rowIndexValue : Object {0: "0", 1: "1", 2: "2", 3: "3", 4: "4", 5: "5", 6: "6", 7: "7", 8: "8", 9: "9", 10: "10", 11: "11", 12: "12", 13: "13", 14: "14", 15: "15", 16: "16", 17: "17", 18: "18", 19: "19", 20: "20", 21: "21", 22: "22", 23: "23", 24: "24", 25: "25", 26: "26", 27: "27", 28: "28", 29: "29", 30: "30", 31: "31", 32: "32", 33: "33", 34: "34", 35: "35", 36: "36", 37: "37", 38: "38", 39: "39", 40: "40", 41: "41", 42: "42", 43: "43", 44: "52"}
rowNameIndex : Object {0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8: 8, 9: 9, 10: 10, 11: 11, 12: 12, 13: 13, 14: 14, 15: 15, 16: 16, 17: 17, 18: 18, 19: 19, 20: 20, 21: 21, 22: 22, 23: 23, 24: 24, 25: 25, 26: 26, 27: 27, 28: 28, 29: 29, 30: 30, 31: 31, 32: 32, 33: 33, 34: 34, 35: 35, 36: 36, 37: 37, 38: 38, 39: 39, 40: 40, 41: 41, 42: 42, 43: 43, 52: 44}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/voyageth/zeppelin patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1093
----
commit 48bc8a498764558526b126af60a35595bace9aff
Author: SungjuKwon <su...@campmobile.com>
Date: 2016-06-27T10:22:11Z
Update paragraph.controller.js
### What is this PR for?
Fix "stackedAreaChart", "lineWithFocusChart" graph when dataset contains "NULL" value.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Check side effect.
* [ ] - Need fix when maxRowValue == rowIdx
### How should this be tested?
Test when row data set is like this on 1777 line.
rowIndexValue : Object {0: "0", 1: "1", 2: "2", 3: "3", 4: "4", 5: "5", 6: "6", 7: "7", 8: "8", 9: "9", 10: "10", 11: "11", 12: "12", 13: "13", 14: "14", 15: "15", 16: "16", 17: "17", 18: "18", 19: "19", 20: "20", 21: "21", 22: "22", 23: "23", 24: "24", 25: "25", 26: "26", 27: "27", 28: "28", 29: "29", 30: "30", 31: "31", 32: "32", 33: "33", 34: "34", 35: "35", 36: "36", 37: "37", 38: "38", 39: "39", 40: "40", 41: "41", 42: "42", 43: "43", 44: "52"}
rowNameIndex : Object {0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8: 8, 9: 9, 10: 10, 11: 11, 12: 12, 13: 13, 14: 14, 15: 15, 16: 16, 17: 17, 18: 18, 19: 19, 20: 20, 21: 21, 22: 22, 23: 23, 24: 24, 25: 25, 26: 26, 27: 27, 28: 28, 29: 29, 30: 30, 31: 31, 32: 32, 33: 33, 34: 34, 35: 35, 36: 36, 37: 37, 38: 38, 39: 39, 40: 40, 41: 41, 42: 42, 43: 43, 52: 44}
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1093: [Bug Fix] Fix "stackedAreaChart", "lineWithFocusChart"...
Posted by voyageth <gi...@git.apache.org>.
Github user voyageth commented on the issue:
https://github.com/apache/zeppelin/pull/1093
Oh, empty string also make wired graph too!
This PR doesn't consider that condition.
This PR can fix following condition.
`%sh echo -e "%table key\tvalue\nnull\t1000\n1\t100\n2\t200\n99\t900"`
- before apply PR
- after apply PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1093: [Bug Fix] Fix "stackedAreaChart", "lineWithFocusChart"...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1093
Thanks @voyageth for the contribution.
I tried reproduce the problem by doing
```
%sh echo -e "%table key\tvalue\n\t1000\n1\t100\n2\t200"
```
And i've got weird graph.
However, the weird graph still remains after applying this proposed fix.
@voyageth, Could you guide me how to reproduce the problem and test this contribution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1093: [Bug Fix] Fix "stackedAreaChart", "lineWithFocusChart"...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1093
@voyageth Thank you for the contribution,
Could you create a jira issue here: https://issues.apache.org/jira/browse/ZEPPELIN
And also provide better details on the bug, it could be:
* A screenshot of GIF of the bug
* Explanations of what is happening and what is expected
As well as some code to input in a paragraph and instructions to reproduce the error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1093: [ZEPPELIN-1103] Fix "stackedAreaChart", "lineWi...
Posted by voyageth <gi...@git.apache.org>.
Github user voyageth closed the pull request at:
https://github.com/apache/zeppelin/pull/1093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---