[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2557: [NETBEANS-5057] fix for indexing JSF composite components

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2557:
URL: https://github.com/apache/netbeans/pull/2557#discussion_r531204781



##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/index/CompositeComponentModel.java
##########
@@ -270,7 +270,7 @@ private static FileObject getResourcesDirectory(FileObject file) {
             if (folder.getName().equalsIgnoreCase("resources")) { //NOI18N
                 //check if its parent is META-INF
                 FileObject parent = folder.getParent();
-                if (parent != null && parent.getNameExt().startsWith("META-INF")) { //NOI18N
+                if (parent != null && parent.getName().startsWith("META-INF")) { //NOI18N

Review comment:
       This should not be necessary. FileObject#getName would be better called "getNameWithoutExtension" and FileObject#getNameExt returns the normal filename. Could you please double check?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists