You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/26 06:59:10 UTC
[kudu-CR] WIP [client] KUDU-3472 C++ client API to import JWT
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19808
Change subject: WIP [client] KUDU-3472 C++ client API to import JWT
......................................................................
WIP [client] KUDU-3472 C++ client API to import JWT
This patch addresses add C++ client API to specify a JWT for a newly
built C++ client instance.
WIP:
* more detailed changelist description
* more tests w.r.t. handling JWT and the rest of the authn creds
(i.e. what to use when both the authn token and JWT is present?)
* should we export JWT part into the authn creds out of a client;
are there any security issues with that (those are primary creds)
Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/integration-tests/security-itest.cc
4 files changed, 87 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19808/1
--
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [client] KUDU-3472 C++ client API to import JWT
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19808 )
Change subject: [client] KUDU-3472 C++ client API to import JWT
......................................................................
[client] KUDU-3472 C++ client API to import JWT
This patch addresses add C++ client API to specify a JWT for a newly
built C++ client instance. It's an improvement in the usability of the
Kudu client API since with this new extra method the users don't need
to mess with the serialization of the authn credentials.
The new functionality is covered by already existing tests that have
been updated to start using the new API. More tests might be added
to cover other aspects of the JWT-related functionality, but these
are not directly related to this API change, so we can take care of them
in a separate patch.
Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Reviewed-on: http://gerrit.cloudera.org:8080/19808
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/integration-tests/security-itest.cc
4 files changed, 87 insertions(+), 60 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [client] KUDU-3472 C++ client API to import JWT
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19808
to look at the new patch set (#2).
Change subject: [client] KUDU-3472 C++ client API to import JWT
......................................................................
[client] KUDU-3472 C++ client API to import JWT
This patch addresses add C++ client API to specify a JWT for a newly
built C++ client instance. It's an improvement in the usability of the
Kudu client API since with this new extra method the users don't need
to mess with the serialization of the authn credentials.
The new functionality is covered by already existing tests that have
been updated to start using the new API. More tests might be added
to cover other aspects of the JWT-related functionality, but these
are not directly related to this API change, so we can take care of them
in a separate patch.
Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/integration-tests/security-itest.cc
4 files changed, 87 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19808/2
--
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [client] KUDU-3472 C++ client API to import JWT
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19808 )
Change subject: [client] KUDU-3472 C++ client API to import JWT
......................................................................
Patch Set 2: Verified+1
unrelated test failures (RELEASE):
* LogRollingITest.TestLogCleanupOnStartup
* RebalanceParamTest.Rebalance/4
--
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 21:59:41 +0000
Gerrit-HasComments: No
[kudu-CR] [client] KUDU-3472 C++ client API to import JWT
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19808 )
Change subject: [client] KUDU-3472 C++ client API to import JWT
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 21:31:19 +0000
Gerrit-HasComments: No
[kudu-CR] [client] KUDU-3472 C++ client API to import JWT
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [client] KUDU-3472 C++ client API to import JWT
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>