You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2019/10/31 12:03:02 UTC
[jira] [Commented] (OAK-8722) dead locking related code in
NodeDelegate.updateMixins
[ https://issues.apache.org/jira/browse/OAK-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963919#comment-16963919 ]
Julian Reschke commented on OAK-8722:
-------------------------------------
Proposed patch: [^OAK-8722.diff]
> dead locking related code in NodeDelegate.updateMixins
> ------------------------------------------------------
>
> Key: OAK-8722
> URL: https://issues.apache.org/jira/browse/OAK-8722
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: OAK-8722.diff
>
>
> {noformat}
> // 3. deal with locked nodes
> boolean wasLockable = isNodeType(MIX_LOCKABLE);
> boolean isLockable = isNodeType(MIX_LOCKABLE);
> if (wasLockable && !isLockable && holdsLock(false)) {
> // TODO: This should probably be done in a commit hook
> unlock();
> sessionDelegate.refresh(true);
> }
> {noformat}
> AFAICT, this code block will never be executed. Clean up, [~angela]?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)