You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/22 15:08:27 UTC

[GitHub] [arrow] pitrou commented on pull request #14351: ARROW-17904: [C++] [WIP] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

pitrou commented on PR #14351:
URL: https://github.com/apache/arrow/pull/14351#issuecomment-1287821476

   Thanks for the PR @mapleFU . I haven't looked in detail yet.
   
   IMHO The testing approach should be to add reference files in https://github.com/apache/parquet-testing/tree/master/data  .
   Ideally these files should provide the given feature matrix:
   * correct and incorrect CRCs
   * v1 and v2 data pages
   * compressed and uncompressed columns
   
   This would probably be spread over two files, one with correct CRCs, one with incorrect CRCs.
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org