About SSL properties in JMeter and their use in Java / HC Impl and Recorder

[Philippe Mouawad <p....@ubik-ingenierie.com>]

Hello,

I see few problems in this field in JMeter.

1) Cipher Suite is configurable through 2 properties:
Documented one called "https.cipherSuites" in HttpSSLProtocolSocketFactory
Undocumented one called "https.socket.ciphers" in
LazyLayeredConnectionSocketFactory

For HC4, the latter is the used one
For Java, the first one is used


I suggest we switch in LazyLayeredConnectionSocketFactory
https.socket.ciphers to https.cipherSuites as the latter is documented

2) It seems it's not possible to control cipher suites and protocols in
HTTP(S) Test Script Recorder, we only allow setting SSLContext algo but
neither SSLSocket protocols nor cipherSuites.

I suggest we set both using the values of properties in Proxy#startSSL:

   - https.cipherSuites
   - https.socket.protocols


Are you ok with my analysis and proposals ?
Thanks
-- 
Cordialement
Philippe M.
Ubik-Ingenierie

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

[Vladimir Sitnikov <si...@gmail.com>]

It is better now.

Frankly speaking I do not know how to deal with separator, and with array
vs List in the API.

In most cases, Lists are more pleasant to work from Java.

However, I would not die on that hill.

Vladimir

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

[Philippe Mouawad <ph...@gmail.com>]

Hello,
I updated PR.

Shall I merge it.

Regards

On Monday, November 15, 2021, Vladimir Sitnikov <si...@gmail.com>
wrote:

> I see,
>
> +1 for unifying the properties.
>
> I don't quite like the naming of the fields:
> String CIPHER_SUITE_LIST becomes String[] SUPPORTED_CIPHER_LIST after
> split(" ").
>
> The names are not that important as the fields are private (which is good),
> however, it is really hard to follow which property goes where.
> It might be JOrphanUtils.split(JMeterUtils.getPropOrDefault(...)...) would
> avoid creating a String fields,
> so you don't have to invent two names for basically the same thing.
>
> ---
>
> It is a bit sad to have different separators for different properties.
> Do you think commas could be used as separators?
>
> Vladimir
>


-- 
Cordialement.
Philippe Mouawad.

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

[Vladimir Sitnikov <si...@gmail.com>]

I see,

+1 for unifying the properties.

I don't quite like the naming of the fields:
String CIPHER_SUITE_LIST becomes String[] SUPPORTED_CIPHER_LIST after
split(" ").

The names are not that important as the fields are private (which is good),
however, it is really hard to follow which property goes where.
It might be JOrphanUtils.split(JMeterUtils.getPropOrDefault(...)...) would
avoid creating a String fields,
so you don't have to invent two names for basically the same thing.

---

It is a bit sad to have different separators for different properties.
Do you think commas could be used as separators?

Vladimir

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

[Philippe Mouawad <p....@ubik-ingenierie.com>]

Hello,
https://github.com/apache/jmeter/pull/677

Regards

On Sun, Nov 14, 2021 at 11:13 AM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:

> Hi,
>
> I do not completely understand the use case, however, I support adding the
> common property names
> so different implementations could be configured in the same way.
>
> So please file the PR with the property names and the supported values.
> I don't understand what do you mean by https.socket.protocols
>
> Vladimir
>


-- 
Cordialement
Philippe M.
Ubik-Ingenierie

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

[Vladimir Sitnikov <si...@gmail.com>]

Hi,

I do not completely understand the use case, however, I support adding the
common property names
so different implementations could be configured in the same way.

So please file the PR with the property names and the supported values.
I don't understand what do you mean by https.socket.protocols

Vladimir