You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/05 17:32:35 UTC

[jira] [Commented] (FLINK-1166) Add a QA bot to Flink that is testing pull requests

    [ https://issues.apache.org/jira/browse/FLINK-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307508#comment-14307508 ] 

ASF GitHub Bot commented on FLINK-1166:
---------------------------------------

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/366

    [FLINK-1166] Add qa-check.sh tool

    The ./tools/qa-check.sh tool allows developers to check for common errors before opening a pull request.
    The qa-checks are designed to be easily extensible by further checks.
    
    
    I'm currently working on some tooling to automatically execute the tool on new pull requests (or on request).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink qa-bot

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #366
    
----

----


> Add a QA bot to Flink that is testing pull requests
> ---------------------------------------------------
>
>                 Key: FLINK-1166
>                 URL: https://issues.apache.org/jira/browse/FLINK-1166
>             Project: Flink
>          Issue Type: New Feature
>          Components: Build System
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>              Labels: starter
>
> We should have a QA bot (similar to Hadoop) that is checking incoming pull requests for a few things:
> - Changes to user-facing APIs
> - More compiler warnings than before
> - more Javadoc warnings than before
> - change of the number of files in the lib/ directory.
> - unused dependencies
> - {{@author}} tag.
> - guava (and other shaded jars) in the lib/ directory.
> It should be somehow extensible to add new tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)