You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/23 13:21:56 UTC
[GitHub] [rocketmq] MatureAndCapable opened a new pull request, #4508: Update README.md
MatureAndCapable opened a new pull request, #4508:
URL: https://github.com/apache/rocketmq/pull/4508
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Update README.md
## Brief changelog
before: Messaging patterns including publish/subscribe, request/reply and streaming
after: Messaging patterns including clustering/broadcasting, publish/subscribe, request/reply
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4508: Update README.md
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on code in PR #4508:
URL: https://github.com/apache/rocketmq/pull/4508#discussion_r905907699
##########
README.md:
##########
@@ -13,7 +13,7 @@
It offers a variety of features:
-* Messaging patterns including publish/subscribe, request/reply and streaming
+* Messaging patterns including clustering/broadcasting, publish/subscribe, request/reply
Review Comment:
The clustering/broadcasting is more of a consumption mode. Making it a messaging pattern might be not that precise. And we do have a streaming pattern, where you could find it in [RocketMQ Streams](https://github.com/apache/rocketmq-streams) and maybe try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4508: Update README.md
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on code in PR #4508:
URL: https://github.com/apache/rocketmq/pull/4508#discussion_r905907699
##########
README.md:
##########
@@ -13,7 +13,7 @@
It offers a variety of features:
-* Messaging patterns including publish/subscribe, request/reply and streaming
+* Messaging patterns including clustering/broadcasting, publish/subscribe, request/reply
Review Comment:
The clustering/broadcasting is a consumption mode. Making it a messaging pattern might be not that precise. And we do have a streaming pattern, where you could find it in [RocketMQ Streams](https://github.com/apache/rocketmq-streams) and maybe try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatureAndCapable commented on pull request #4508: Update README.md
Posted by "MatureAndCapable (via GitHub)" <gi...@apache.org>.
MatureAndCapable commented on PR #4508:
URL: https://github.com/apache/rocketmq/pull/4508#issuecomment-1641168261
您好， 您的信件已收到，我会尽快处理，谢谢。祝好！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatureAndCapable commented on pull request #4508: Update README.md
Posted by GitBox <gi...@apache.org>.
MatureAndCapable commented on PR #4508:
URL: https://github.com/apache/rocketmq/pull/4508#issuecomment-1164517588
您好， 您的信件已收到，我会尽快处理，谢谢。祝好！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on pull request #4508: Update README.md
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4508:
URL: https://github.com/apache/rocketmq/pull/4508#issuecomment-1641166522
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org