You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/17 07:36:20 UTC

[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2797: Make maxConcurrentZkRequests for gc configurable

nicoloboschi commented on a change in pull request #2797:
URL: https://github.com/apache/bookkeeper/pull/2797#discussion_r710822934



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -111,6 +111,8 @@
     protected static final String GC_WAIT_TIME = "gcWaitTime";
     protected static final String IS_FORCE_GC_ALLOW_WHEN_NO_SPACE = "isForceGCAllowWhenNoSpace";
     protected static final String GC_OVERREPLICATED_LEDGER_WAIT_TIME = "gcOverreplicatedLedgerWaitTime";
+    protected static final String GC_OVERREPLICATED_LEDGER_MAX_CONCURRENT_ZK_REQUESTS =

Review comment:
       since this property is not tightly related to ZK but it's more a logical option, IMHO we should not mention ZK in the name of the property
   GC_OVERREPLICATED_LEDGER_MAX_CONCURRENT_REQUESTS ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org