You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafodion.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/03 16:17:00 UTC
[jira] [Commented] (TRAFODION-1610) Generate constraint expression
for update/merge commands
[ https://issues.apache.org/jira/browse/TRAFODION-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189922#comment-16189922 ]
ASF GitHub Bot commented on TRAFODION-1610:
-------------------------------------------
GitHub user DaveBirdsall opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1253
[TRAFODION-1610][TRAFODION-2630] Generate constr exprs on update operators
This set of changes plugs a hole in our implementation of update/upsert/merge operators. It completes work started by JIRA TRAFODION-1575.
This set of changes adds logic to the generator to generate update constraint check and insert constraint check expressions for update operators. (The update constraint check handles the run-time update path; the insert constraint check handles the run-time insert path for upsert and merge; it is absent for vanilla update and for merges that lack a "when not matched" clause.)
This set of changes also removes temporary code added long ago that transformed an UPDATE to an INSERT + a DELETE when constraint expressions were present. (The INSERT operator had a correct implementation of constraint checking.) This should make many non-key-column UPDATEs faster, and will also eliminate the possibility of HBase timestamp collisions because the INSERT happens within a millisecond of the DELETE.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion1610
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1253
----
commit c22b6d10fdd3065a948163d64a20c3039128474c
Author: Dave Birdsall <db...@apache.org>
Date: 2017-10-03T16:09:29Z
[TRAFODION-1610][TRAFODION-2630] Generate constr exprs on update operators
----
> Generate constraint expression for update/merge commands
> --------------------------------------------------------
>
> Key: TRAFODION-1610
> URL: https://issues.apache.org/jira/browse/TRAFODION-1610
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: David Wayne Birdsall
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)